Unify private names treatment.

Unify private names treatment.

This change actually revealed a couple of problems we had. I am planning to
switch to even more unified treatment of privates and force renames at
visitIdentifier level.

R=smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=11027

[Roman, 2012-08-21 07:34:17]

https://chromiumcodereview.appspot.com/10837343/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10837343/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:37: if
(element === null || element.isMember()) {
We didn't rename static fields before, why should we?

https://chromiumcodereview.appspot.com/10837343/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/renamer.dart (right):

https://chromiumcodereview.appspot.com/10837343/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:29:
.putIfAbsent(originalName, () => generateUniqueName(originalName));
I don't understand this. Earlier we had different prefixes for private
identifiers that appear in different libraries. Now they may be equal, but I
don't think that's what we want.

[Roman, 2012-08-21 09:50:01]

lgtm