Issue 10837282: Issue 4518. Use inferred types to check if type of argumetn is assignable to the type of parameter

Issue 10837282: Issue 4518. Use inferred types to check if type of argumetn is assignable to the type of parameter (Closed)

Created:
8 years, 4 months ago by scheglov

Modified:
8 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 4518. Use inferred types to check if type of argumetn is assignable to the type of parameter http://code.google.com/p/dart/issues/detail?id=4518 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10825

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -39 lines)			Patch
M	compiler/java/com/google/dart/compiler/CommandLineOptions.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	6 chunks	+9 lines, -7 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	10 chunks	+59 lines, -17 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.properties	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://chromiumcodereview.appspot.com/10837282/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java (right): https://chromiumcodereview.appspot.com/10837282/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java#newcode280 compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:280: * constants, of type int or String. I ...

8 years, 4 months ago (2012-08-16 13:56:54 UTC) #2

scheglov

8 years, 4 months ago (2012-08-16 14:29:41 UTC) #3

https://chromiumcodereview.appspot.com/10837282/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

https://chromiumcodereview.appspot.com/10837282/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:280:
* constants, of type int or String.
On 2012/08/16 13:56:54, Brian Wilkerson wrote:
> I don't have the spec available, but I think this restriction has been relaxed
> to allow compile-time constants of the same (any) type.

Yes.
I'm going to implement this.
But in this CL I just wanted to tweak comment to make it correct for current
implementation.

Expand Messages | Collapse Messages