Issue 4518. Use inferred types to check if type of argumetn is assignable to the type of parameter

compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
index 254863ed560f475acc12c1d5c9873c02367ee6f5..718ce2f10a4f52c0013fc78acc7ee7362ed0fc4e 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
@@ -276,15 +276,15 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
   }
 
   /**
-   * It is a compile-time error if the values of the case expressions do not all have the same type.
+   * It is a compile-time error if the values of the case expressions are not compile-time
+   * constants, of type int or String.

[Brian Wilkerson, 2012/08/16 13:56:54]

I don't have the spec available, but I think this restriction has been relaxed
to allow compile-time constants of the same (any) type.

[scheglov, 2012/08/16 14:29:41]

Yes.
I'm going to implement this.
But in this CL I just wanted to tweak comment to make it correct for current
implementation.

    * <p>
    * http://code.google.com/p/dart/issues/detail?id=3528
    */
   public void test_switchExpression_case_notIntString() throws Exception {
     AnalyzeLibraryResult libraryResult = analyzeLibrary(
         "// filler filler filler filler filler filler filler filler filler filler",
-        "main() {",
-        "  var v = 1;",
+        "foo(var v) {",
         "  switch (v) {",
         "    case 0: break;",
         "  }",
@@ -298,7 +298,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
         "");
     assertErrors(
         libraryResult.getErrors(),
-        errEx(TypeErrorCode.CASE_EXPRESSION_SHOULD_BE_INT_STRING, 11, 10, 3));
+        errEx(TypeErrorCode.CASE_EXPRESSION_SHOULD_BE_INT_STRING, 10, 10, 3));
   }
 
   /**
@@ -309,8 +309,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
   public void test_switchExpression_case_differentTypes() throws Exception {
     AnalyzeLibraryResult libraryResult = analyzeLibrary(
         "// filler filler filler filler filler filler filler filler filler filler",
-        "main() {",
-        "  var v = 1;",
+        "foo(var v) {",
         "  switch (v) {",
         "    case 0: break;",
         "    case 'a': break;",
@@ -319,7 +318,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
         "");
     assertErrors(
         libraryResult.getErrors(),
-        errEx(TypeErrorCode.CASE_EXPRESSIONS_SHOULD_BE_SAME_TYPE, 6, 10, 3));
+        errEx(TypeErrorCode.CASE_EXPRESSIONS_SHOULD_BE_SAME_TYPE, 5, 10, 3));
   }
 
   /**
@@ -1758,7 +1757,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
   }
 
   public void test_inferredTypes_noMemberWarnings() throws Exception {
-    // report by default
+    // disabled by default
     {
       AnalyzeLibraryResult result = analyzeLibrary(
           "// filler filler filler filler filler filler filler filler filler filler",
@@ -1773,17 +1772,14 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
           "  v.m();",
           "}",
           "");
-      assertErrors(
-          result.getErrors(),
-          errEx(TypeErrorCode.NOT_A_MEMBER_OF, 9, 5, 1),
-          errEx(TypeErrorCode.INTERFACE_HAS_NO_METHOD_NAMED, 10, 5, 1));
+      assertErrors(result.getErrors());
     }
-    // use CompilerConfiguration to suppress
+    // use CompilerConfiguration to enable
     {
       compilerConfiguration = new DefaultCompilerConfiguration(new CompilerOptions() {
         @Override
-        public boolean memberWarningForInferredTypes() {
-          return false;
+        public boolean typeChecksForInferredTypes() {
+          return true;
         }
       });
       AnalyzeLibraryResult result = analyzeLibrary(
@@ -1799,7 +1795,10 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
           "  v.m();",
           "}",
           "");
-      assertErrors(result.getErrors());
+      assertErrors(
+          result.getErrors(),
+          errEx(TypeErrorCode.NOT_A_MEMBER_OF, 9, 5, 1),
+          errEx(TypeErrorCode.INTERFACE_HAS_NO_METHOD_NAMED, 10, 5, 1));
     }
   }
 
@@ -1812,7 +1811,7 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
   public void test_inferredTypes_noMemberWarnings_forInLoop() throws Exception {
       compilerConfiguration = new DefaultCompilerConfiguration(new CompilerOptions() {
         @Override
-        public boolean memberWarningForInferredTypes() {
+        public boolean typeChecksForInferredTypes() {
           return false;
         }
       });
@@ -1829,6 +1828,45 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
       assertErrors(result.getErrors());
   }
 
+  public void test_inferredTypes_whenInvocationArgument_checkAssignable() throws Exception {
+    // disabled by default
+    {
+      AnalyzeLibraryResult result = analyzeLibrary(
+          "// filler filler filler filler filler filler filler filler filler filler",
+          "class A {}",
+          "class B {}",
+          "foo(A a) {}",
+          "main() {",
+          "  var v = new B();",
+          "  foo(v);",
+          "}",
+          "");
+      assertErrors(result.getErrors());
+    }
+    // use CompilerConfiguration to enable
+    {
+      compilerConfiguration = new DefaultCompilerConfiguration(new CompilerOptions() {
+        @Override
+        public boolean typeChecksForInferredTypes() {
+          return true;
+        }
+      });
+      AnalyzeLibraryResult result = analyzeLibrary(
+          "// filler filler filler filler filler filler filler filler filler filler",
+          "class A {}",
+          "class B {}",
+          "foo(A a) {}",
+          "main() {",
+          "  var v = new B();",
+          "  foo(v);",
+          "}",
+          "");
+      assertErrors(
+          result.getErrors(),
+          errEx(TypeErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE, 7, 7, 1));
+    }
+  }
+
   public void test_typesPropagation_assignAtDeclaration() throws Exception {
     analyzeLibrary(
         "f() {",
@@ -2507,6 +2545,10 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
    * should not do this to completely satisfy specification.
    * <p>
    * http://code.google.com/p/dart/issues/detail?id=3223
+   * <p>
+   * This feature was requested by users, so we introduce it again, but disabled to command line.
+   * <p>
+   * http://code.google.com/p/dart/issues/detail?id=4518
    */
   public void test_typesPropagation_noExtraWarnings() throws Exception {
     AnalyzeLibraryResult libraryResult = analyzeLibrary(