Issue 4383. Calling field without setter should generate problem

Issue 4383. Calling field without setter should generate problem
http://code.google.com/p/dart/issues/detail?id=4383


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=10649

[Brian Wilkerson, 2012-08-14 14:08:38]

https://chromiumcodereview.appspot.com/10837237/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

https://chromiumcodereview.appspot.com/10837237/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:27:
CANNOT_CALL_FIELD_WITHOUT_GETTER("Cannot call field without setter"),
Can we find a better way of saying this? Most users probably don't think about
"calling" a field. How about "access" or "assign"? (By the way, the message and
the CL description say "setter", but the code says "getter". They should be the
same.

[scheglov, 2012-08-14 14:19:45]

https://chromiumcodereview.appspot.com/10837237/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

https://chromiumcodereview.appspot.com/10837237/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:27:
CANNOT_CALL_FIELD_WITHOUT_GETTER("Cannot call field without setter"),
On 2012/08/14 14:08:39, Brian Wilkerson wrote:
> Can we find a better way of saying this? Most users probably don't think about
> "calling" a field. How about "access" or "assign"? (By the way, the message
and
> the CL description say "setter", but the code says "getter". They should be
the
> same.

Well, formally this should be "can not access 'this' from static context"

Now we will use same error message as generate for warning.

[Brian Wilkerson, 2012-08-14 14:22:55]

LGTM