Issue 10837236: Fix dangling else.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837236: Fix dangling else. (Closed)

Created:
8 years, 4 months ago by floitsch

Modified:
8 years, 4 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dangling else. Fixes issue 4493. Committed: https://code.google.com/p/dart/source/detail?r=10645

Patch Set 2 : Add forgotten test. #

Total comments: 2

Patch Set 3 : Address comment. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -17 lines)			Patch
	M	lib/compiler/implementation/js/printer.dart	View	1 2	3 chunks	+61 lines, -17 lines	0 comments	Download
	A	tests/language/dangling_else_test.dart	View	1	1 chunk	+82 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10837236/diff/2002/lib/compiler/implementation/js/printer.dart File lib/compiler/implementation/js/printer.dart (right): https://chromiumcodereview.appspot.com/10837236/diff/2002/lib/compiler/implementation/js/printer.dart#newcode143 lib/compiler/implementation/js/printer.dart:143: NodeVisitor danglingElseVisitor = new DanglingElseVisitor(compiler); Can this be ...

8 years, 4 months ago (2012-08-14 13:42:24 UTC) #3

floitsch

8 years, 4 months ago (2012-08-14 13:46:48 UTC) #4

https://chromiumcodereview.appspot.com/10837236/diff/2002/lib/compiler/implem...
File lib/compiler/implementation/js/printer.dart (right):

https://chromiumcodereview.appspot.com/10837236/diff/2002/lib/compiler/implem...
lib/compiler/implementation/js/printer.dart:143: NodeVisitor danglingElseVisitor
= new DanglingElseVisitor(compiler);
On 2012/08/14 13:42:24, kasperl wrote:
> Can this be reused? There's no state in the visitor (except for the compiler).

Done.