Fix dangling else.

lib/compiler/implementation/js/printer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Printer implements NodeVisitor {
   final bool shouldCompressOutput = false;
   leg.Compiler compiler;
   var positionElement;
   leg.CodeBuffer outBuffer;
   int indentLevel = 0;
@@ skipping 119 matching lines @@
   }
 
   visitEmptyStatement(EmptyStatement nop) {
     outIndentLn(";");
   }
 
   void ifOut(If node, bool shouldIndent) {
     Node then = node.then;
     Node elsePart = node.otherwise;
     bool hasElse = node.hasElse;
+
     // Handle dangling elses.
-    // If the then-branch is an if, which has no else-branch, but we do
-    // have one, then we need to put the nested if into braces.
-    if (hasElse && then is If) {
-      Node nested = then;
-      do {
-        If nestedIf = nested;
-        if (!nestedIf.hasElse) {
-          then = new Block(<Statement>[then]);
-          break;
-        }
-        nested = nestedIf.otherwise;
-      } while (nested is If);
-    }
-    if (then is If && !(then as If).hasElse && hasElse) {
-      then = new Block(<Statement>[then]);
+    if (hasElse) {
+      NodeVisitor danglingElseVisitor = new DanglingElseVisitor(compiler);

[kasperl, 2012/08/14 13:42:24]

Can this be reused? There's no state in the visitor (except for the compiler).

[floitsch, 2012/08/14 13:46:48]

Done.

+      bool needsBraces = node.then.accept(danglingElseVisitor);
+      if (needsBraces) {
+        then = new Block(<Statement>[then]);
+      }
     }
     if (shouldIndent) indent();
     out("if");
     spaceOut();
     out("(");
     visitNestedExpression(node.condition, EXPRESSION,
                           newInForInit: false, newAtStatementBegin: false);
     out(")");
     bool thenWasBlock =
         blockBody(then, needsSeparation: false, needsNewline: !hasElse);
@@ skipping 596 matching lines @@
       out(parts[i + 1]);
     }
     out(")");
   }
 
   visitLiteralStatement(LiteralStatement node) {
     outLn(node.code);
   }
 }
 
+/**
+ * Returns true, if the given node must be wrapped into braces when used
+ * as then-statement in an [If] that has an else branch.
+ */
+class DanglingElseVisitor extends BaseVisitor<bool> {
+  leg.Compiler compiler;
+
+  DanglingElseVisitor(this.compiler);
+
+  bool visitProgram(Program node) => false;
+
+  bool visitNode(Statement node) {
+    compiler.internalError("Forgot node: $node");
+  }
+
+  bool visitBlock(Block node) => false;
+  bool visitExpressionStatement(ExpressionStatement node) => false;
+  bool visitEmptyStatement(EmptyStatement node) => false;
+  bool visitIf(If node) {
+    if (!node.hasElse) return true;
+    return node.otherwise.accept(this);
+  }
+  bool visitFor(For node) => node.body.accept(this);
+  bool visitForIn(ForIn node) => node.body.accept(this);
+  bool visitWhile(While node) => node.body.accept(this);
+  bool visitDo(Do node) => false;
+  bool visitContinue(Continue node) => false;
+  bool visitBreak(Break node) => false;
+  bool visitReturn(Return node) => false;
+  bool visitThrow(Throw node) => false;
+  bool visitTry(Try node) {
+    if (node.finallyPart != null) {
+      return node.finallyPart.accept(this);
+    } else {
+      return node.catchPart.accept(this);
+    }
+  }
+  bool visitCatch(Catch node) => node.body.accept(this);
+  bool visitSwitch(Switch node) => false;
+  bool visitCase(Case node) => false;
+  bool visitDefault(Default node) => false;
+  bool visitFunctionDeclaration(FunctionDeclaration node) => false;
+  bool visitLabeledStatement(LabeledStatement node)
+      => node.body.accept(this);
+  bool visitLiteralStatement(LiteralStatement node) => true;
+
+  bool visitExpression(Expression node) => false;
+}
+
+
 leg.CodeBuffer prettyPrint(Node node,
                            leg.Compiler compiler,
                            Dynamic positionElement) {
   Printer printer = new Printer(compiler, positionElement);
   printer.visit(node);
   return printer.outBuffer;
 }