Issue 10837194: Fix for inferred type warnings pref page

Issue 10837194: Fix for inferred type warnings pref page (Closed)

Created:
8 years, 4 months ago by scheglov

Modified:
8 years, 4 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for inferred type warnings pref page Finishes http://codereview.chromium.org/10829255/ fix. R=devoncarew@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10467

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -25 lines)			Patch
M	compiler/java/com/google/dart/compiler/CommandLineOptions.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.properties	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

devoncarew

lgtm Looks good. Have you thought about adding a grouping box around the controls? :-) ...

8 years, 4 months ago (2012-08-09 22:37:57 UTC) #2

scheglov

> > Have you thought about adding a grouping box around the controls? > :-) ...

8 years, 4 months ago (2012-08-09 22:50:36 UTC) #3

scheglov

8 years, 4 months ago (2012-08-09 22:50:42 UTC) #4

http://codereview.chromium.org/10837194/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java
(right):

http://codereview.chromium.org/10837194/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java:55:
true);
On 2012/08/09 22:37:57, devoncarew wrote:
> Do we want this to default to true?

Fixed.
Thank you.

Expand Messages | Collapse Messages