Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java

Issue 10837194: Fix for inferred type warnings pref page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java
diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java
index a929053ab3916fa3e8204a0daf95c74f272b2588..39a49cebb406fb45641bbb4e140f71d8e8774409 100644
--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java
+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java
@@ -53,7 +53,7 @@ public class DartAnalysisPreferencePage extends PreferencePage implements IWorkb
return checkBox;
}
- private Button warningForInferredTypes_check;
+ private Button memberWarningForInferredTypes_check;
public DartAnalysisPreferencePage() {
setPreferenceStore(null);
@@ -68,9 +68,9 @@ public class DartAnalysisPreferencePage extends PreferencePage implements IWorkb
public boolean performOk() {
boolean hasChanges = false;
hasChanges |= applyCheck(
- DartCore.SUPPRESS_NO_MEMBER_FOR_INFERRED_TYPES,
- !warningForInferredTypes_check.getSelection(),
- true);
+ DartCore.MEMBER_WARNING_FOR_INFERRED_TYPES,
+ memberWarningForInferredTypes_check.getSelection(),
+ false);
if (hasChanges) {
Job job = new CleanLibrariesJob();
job.schedule();
@@ -83,9 +83,9 @@ public class DartAnalysisPreferencePage extends PreferencePage implements IWorkb
Composite composite = new Composite(parent, SWT.NONE);
GridLayoutFactory.fillDefaults().spacing(0, 8).margins(0, 10).applyTo(composite);
// create UI
- warningForInferredTypes_check = createCheckBox(
+ memberWarningForInferredTypes_check = createCheckBox(
composite,
- PreferencesMessages.DartAnalysisPreferencePage_suppressNoMemberWarningForInferredTypes,
+ PreferencesMessages.DartAnalysisPreferencePage_memberWarningForInferredTypes,
null);
// done
initFromPrefs();
@@ -94,9 +94,9 @@ public class DartAnalysisPreferencePage extends PreferencePage implements IWorkb
private void initFromPrefs() {
IEclipsePreferences prefs = DartCore.getPlugin().getPrefs();
- warningForInferredTypes_check.setSelection(!prefs.getBoolean(
- DartCore.SUPPRESS_NO_MEMBER_FOR_INFERRED_TYPES,
- true));
+ memberWarningForInferredTypes_check.setSelection(prefs.getBoolean(
+ DartCore.MEMBER_WARNING_FOR_INFERRED_TYPES,
+ false));
}
}

Powered by Google App Engine
This is Rietveld 408576698