Parse metadata, but ignore it.

Parse metadata, but ignore it.

Committed: https://code.google.com/p/dart/source/detail?r=11029

[ahe, 2012-08-20 21:43:03]

I'm testing this with:

./tools/test.py -mrelease -cdart2js -rnone --time -pcolor --report
--host-checked dart2js_foreign

[kasperl, 2012-08-21 05:40:43]

LGTM.

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/scanner.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/scanner.dart:675: int
tokenizeRawString(int next) {
This probably needs a different name now. Is tokenizeRawStringOrMetadataStart
too much of a mouthful?

[ahe, 2012-08-21 05:50:36]

FYI, I need LGTM on this one first:
https://chromiumcodereview.appspot.com/10823423/

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/scanner.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/scanner.dart:675: int
tokenizeRawString(int next) {
On 2012/08/21 05:40:43, kasperl wrote:
> This probably needs a different name now. Is tokenizeRawStringOrMetadataStart
> too much of a mouthful?

I think we're changing the syntax for raw strings, so this method will probably
end up being called something like tokenizeRawStringOrIdentifier.

[ngeoffray, 2012-08-21 06:28:31]

LGTM

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/parser.dart:27: token =
parseMetadataStar(token);
What's the Star suffix for? for consistency, shouldn't it be parseMetadataOpt?

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/partial_parser.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/partial_parser.dart:14: Token
parseArgumentsOpt(Token token) {
Could you comment on why metadata needs you to add this method?

[Johnni Winther, 2012-08-21 07:05:31]

LGTM

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/parser.dart:27: token =
parseMetadataStar(token);
On 2012/08/21 06:28:31, ngeoffray wrote:
> What's the Star suffix for? for consistency, shouldn't it be parseMetadataOpt?

Star means 0 or more. Opt means 0 or 1.

[ahe, 2012-08-21 07:07:10]

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/parser.dart:27: token =
parseMetadataStar(token);
On 2012/08/21 06:28:31, ngeoffray wrote:
> What's the Star suffix for? for consistency, shouldn't it be parseMetadataOpt?

The suffix "star" refers to the asterisk in grammar rules:

metadata*

The suffix "opt" refers to the question mark in grammar rules:

metadata: qualified arguments?

Often I have been able to use:

parseFoo and parseFoos

But parseMetadatas doesn't sound right.

[ahe, 2012-08-21 10:49:46]

Thank you for all your suggestions and comments.

I'm going to submit this now, but I would appreciate if someone proof reads the
comments I added. It wouldn't be the fist time I made a spelling error.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/parser.dart:27: token =
parseMetadataStar(token);
On 2012/08/21 06:28:31, ngeoffray wrote:
> What's the Star suffix for? for consistency, shouldn't it be parseMetadataOpt?

I have updated the class comment.

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/partial_parser.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/partial_parser.dart:14: Token
parseArgumentsOpt(Token token) {
On 2012/08/21 06:28:31, ngeoffray wrote:
> Could you comment on why metadata needs you to add this method?

Done.

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/scanner.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/scanner.dart:675: int
tokenizeRawString(int next) {
On 2012/08/21 05:40:43, kasperl wrote:
> This probably needs a different name now. Is tokenizeRawStringOrMetadataStart
> too much of a mouthful?

Done. Renamed to tokenizeAtOrRawString.

[ngeoffray, 2012-08-21 10:51:20]

LGTM

https://chromiumcodereview.appspot.com/10836351/diff/7002/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/7002/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/parser.dart:24: * matches, "star" means
zero or more matches. For example,
zero or one match

[ahe, 2012-08-21 10:55:37]

https://chromiumcodereview.appspot.com/10836351/diff/7002/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10836351/diff/7002/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/parser.dart:24: * matches, "star" means
zero or more matches. For example,
On 2012/08/21 10:51:21, ngeoffray wrote:
> zero or one match

I don't think that is correct.

"star" means i repetitions where 0 <= i.

"opt" means i repetitions where i = 0 or i = 1.