Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 10836241: Move unittest from lib to pkg. (Closed)

Created:
8 years, 4 months ago by dgrove
Modified:
8 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move unittest from lib to pkg. Committed: https://code.google.com/p/dart/source/detail?r=10685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -6100 lines) Patch
D lib/unittest/collection_matchers.dart View 1 chunk +0 lines, -199 lines 0 comments Download
D lib/unittest/config.dart View 1 chunk +0 lines, -138 lines 0 comments Download
D lib/unittest/core_matchers.dart View 1 chunk +0 lines, -626 lines 0 comments Download
D lib/unittest/coverage_controller.js View 1 chunk +0 lines, -31 lines 0 comments Download
D lib/unittest/description.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D lib/unittest/dom_config.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D lib/unittest/expect.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D lib/unittest/future_matchers.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D lib/unittest/html_config.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D lib/unittest/html_enhanced_config.dart View 1 chunk +0 lines, -370 lines 0 comments Download
D lib/unittest/html_print.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D lib/unittest/interactive_html_config.dart View 1 chunk +0 lines, -656 lines 0 comments Download
D lib/unittest/interfaces.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D lib/unittest/map_matchers.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D lib/unittest/matcher.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D lib/unittest/mock.dart View 1 chunk +0 lines, -1459 lines 0 comments Download
D lib/unittest/numeric_matchers.dart View 1 chunk +0 lines, -229 lines 0 comments Download
D lib/unittest/operator_matchers.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D lib/unittest/string_matchers.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D lib/unittest/test_case.dart View 1 chunk +0 lines, -110 lines 0 comments Download
D lib/unittest/test_controller.js View 1 chunk +0 lines, -75 lines 0 comments Download
D lib/unittest/unittest.dart View 1 chunk +0 lines, -861 lines 0 comments Download
D lib/unittest/vm_config.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M + pkg/unittest/interactive_html_config.dart View 1 chunk +1 line, -1 line 0 comments Download
M + pkg/unittest/unittest.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M samples/markdown/test/markdown_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/tests/samples/dartcombat/dartcombat_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/layout/layout_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/observable/observable_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/touch/touch_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/util/util_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/view/view_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/swarm/swarm_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/async_window_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/audiocontext_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/audioelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/b_element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/blob_constructor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cache_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/callbacks_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvas_pixel_array_type_alias_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvas_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvas_using_html_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cross_frame_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/css_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dart_object_local_storage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/document_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/documentfragment_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dom_constructors_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dom_isolates_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/domparser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_classes_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_constructor_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/event_customevent_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/event_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/events_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/exceptions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/fileapi_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/hidden_dom_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/hidden_dom_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/history_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlaudioelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlcollection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmloptionscollection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/inner_frame_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/instance_of_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/isolates_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/key_name_location_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/localstorage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/location_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/measurement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/messageevent_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/mutationobserver_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/native_gc_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/performance_api_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/query_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/queryall_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/request_animation_frame_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/serialized_script_value_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/shadow_dom_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/storage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svg_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svg_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svg_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svgelement2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svgelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/transferables_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_5_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_arraybuffer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_dataview_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_range_checks_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typing_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/unknownelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/webgl_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/websocket_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_eq_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_mangling_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_nosuchmethod_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_open_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xhr_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xmldocument_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xmlelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xsltprocessor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/compute_this_script_browser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/count_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/cross_isolate_message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate3_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate_complex_messages_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/mandel_isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/message2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/mint_maker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/nested_spawn2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/nested_spawn_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/request_reply_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_function_custom_class_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_function_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_vm_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/unresolved_ports_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/unresolved_ports_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/json/json_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/args/args_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/i18n/bidi_format_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/i18n/bidi_utils_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/i18n/date_time_format_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/i18n/intl_message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/i18n/intl_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/logging/logging_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/mirrors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/unittest/instance_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/unittest/matchers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/unittest/mock_regexp_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/unittest/mock_stepwise_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/unittest/mock_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/unittest/unittest_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/utils/dartdoc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/utils/markdown_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/testing/dart/browser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/apidoc.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/archive/reader_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/archive/utils_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/lock_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/version_solver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/version_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/yaml_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dgrove
As usual, the code review tool doesn't reflect directory moves accurately, so you'll just have ...
8 years, 4 months ago (2012-08-14 17:36:23 UTC) #1
Bob Nystrom
8 years, 4 months ago (2012-08-14 20:04:16 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698