Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 10836237: Sharing of sources for corelib date implementation between VM and (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Sharing of sources for corelib date implementation between VM and dart2js. R=iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10794

Patch Set 1 #

Patch Set 2 : Comment out the patch keyword instead of type #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1089 lines) Patch
M corelib/src/implementation/corelib_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + corelib/src/implementation/date.dart View 4 chunks +8 lines, -5 lines 0 comments Download
D corelib/unified/core/date.dart View 1 chunk +0 lines, -217 lines 0 comments Download
D corelib/unified/core/implementation/date.dart View 1 chunk +0 lines, -181 lines 0 comments Download
M lib/compiler/implementation/lib/coreimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/coreimpl.dartp View 1 chunk +7 lines, -0 lines 0 comments Download
D runtime/lib/date.dart View 1 chunk +0 lines, -492 lines 0 comments Download
A + runtime/lib/date_patch.dart View 1 9 chunks +27 lines, -192 lines 1 comment Download
M runtime/lib/lib_impl_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
This depends on landing something like: https://chromiumcodereview.appspot.com/10831323/ to make tests that use --compile_all pass. https://chromiumcodereview.appspot.com/10836237/diff/2001/runtime/lib/date_patch.dart ...
8 years, 4 months ago (2012-08-15 09:47:28 UTC) #1
Mads Ager (google)
Adding Lasse as well.
8 years, 4 months ago (2012-08-15 09:47:58 UTC) #2
Anders Johnsen
8 years, 4 months ago (2012-08-15 10:15:12 UTC) #3
LGTM, very nice. I like you didn't do any further cleanup - we can do that later
on if needed.

Powered by Google App Engine
This is Rietveld 408576698