Issue 10834387: Stop keeping track of the which library use which private selectors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834387: Stop keeping track of the which library use which private selectors. (Closed)

Created:
8 years, 4 months ago by kasperl

Modified:
8 years, 4 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stop keeping track of the which library use which private selectors. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10889

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -43 lines)			Patch
	M	lib/compiler/implementation/js_backend/emitter.dart	View		3 chunks	+25 lines, -33 lines	2 comments	Download
	M	lib/compiler/implementation/namer.dart	View		2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10834387/diff/1/lib/compiler/implementation/js_backend/emitter.dart File lib/compiler/implementation/js_backend/emitter.dart (right): https://chromiumcodereview.appspot.com/10834387/diff/1/lib/compiler/implementation/js_backend/emitter.dart#newcode924 lib/compiler/implementation/js_backend/emitter.dart:924: void addNoSuchMethodHandlers(SourceString ignore, Set<Selector> selectors) { Should you ...

8 years, 4 months ago (2012-08-17 11:56:57 UTC) #2

kasperl

8 years, 4 months ago (2012-08-17 12:08:44 UTC) #3

https://chromiumcodereview.appspot.com/10834387/diff/1/lib/compiler/implement...
File lib/compiler/implementation/js_backend/emitter.dart (right):

https://chromiumcodereview.appspot.com/10834387/diff/1/lib/compiler/implement...
lib/compiler/implementation/js_backend/emitter.dart:924: void
addNoSuchMethodHandlers(SourceString ignore, Set<Selector> selectors) {
On 2012/08/17 11:56:57, ngeoffray wrote:
> Should you remove the parameter then?

The plan is to have it go away once we change the invokedNames, invokedGetters,
and invokedSetters to be sets rather than maps from names to selectors.

Expand Messages | Collapse Messages