Stop keeping track of the which library use which private selectors.

lib/compiler/implementation/js_backend/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
 class ClosureInvocationElement extends FunctionElement {
   ClosureInvocationElement(SourceString name,
@@ skipping 903 matching lines @@
         if (i != 0) args.add(', ');
         args.add('\$$i');
       }
       CodeBuffer buffer = new CodeBuffer();
       buffer.add('function($args) {\n');
       buffer.add('  return this.$noSuchMethodName("$methodName", [$args]);\n');
       buffer.add(' }');
       return buffer;
     }
 
-    void addNoSuchMethodHandlers(SourceString name, Set<Selector> selectors) {
-      // TODO(kasperl): We should really teach private selectors about
-      // which libraries they are used from. That way, we wouldn't
-      // have to conservatively generate versions for all libraries
-      // the name is used from.
-      String nameString = name.slowToString();
-      Collection<LibraryElement> libraries = name.isPrivate()
-          ? namer.usedPrivateNames[nameString]
-          : const [ null ];
-
+    void addNoSuchMethodHandlers(SourceString ignore, Set<Selector> selectors) {

[ngeoffray, 2012/08/17 11:56:57]

Should you remove the parameter then?

[kasperl, 2012/08/17 12:08:44]

The plan is to have it go away once we change the invokedNames, invokedGetters,
and invokedSetters to be sets rather than maps from names to selectors.

       // Cache the object class and type.
       ClassElement objectClass = compiler.objectClass;
       Type objectType = objectClass.computeType(compiler);
 
       for (Selector selector in selectors) {
         // Introduce a helper function that determines if the given
         // class has a member that matches the current name and
         // selector (grabbed from the scope).
         bool hasMatchingMember(ClassElement holder) {
-          Element element = holder.lookupMember(name);
+          Element element = holder.lookupMember(selector.name);
           if (element === null) return false;
 
           // TODO(kasperl): Consider folding this logic into the
           // Selector.applies() method.
           if (element is AbstractFieldElement) {
             AbstractFieldElement field = element;
             if (selector.kind === SelectorKind.GETTER) {
               return field.getter !== null;
             } else if (selector.kind === SelectorKind.SETTER) {
               return field.setter !== null;
@@ skipping 53 matching lines @@
         // If we're calling bar on an object of type D, we don't need
         // the handler either because all objects of type D implement
         // bar through inheritance.
         //
         // If we're calling bar on an object of type A we do need the
         // handler because we may have to call B.noSuchMethod since B
         // does not implement bar.
         Set<ClassElement> holders = noSuchMethodHoldersFor(receiverType);
         if (holders.every(hasMatchingMember)) continue;
 
-        for (LibraryElement lib in libraries) {
-          String jsName = null;
-          String methodName = null;
-          if (selector.isGetter()) {
-            jsName = namer.getterName(lib, name);
-            methodName = 'get:$nameString';
-          } else if (selector.isSetter()) {
-            jsName = namer.setterName(lib, name);
-            methodName = 'set:$nameString';
-          } else if (selector.isCall()) {
-            jsName = namer.instanceMethodInvocationName(lib, name, selector);
-            methodName = nameString;
-          } else {
-            // We simply ignore selectors that do not need
-            // noSuchMethod handlers.
-            continue;
-          }
-          if (!addedJsNames.contains(jsName)) {
-            CodeBuffer jsCode = generateMethod(methodName, selector);
-            defineInstanceMember(jsName, jsCode);
-            addedJsNames.add(jsName);
-          }
+        String jsName = null;
+        String methodName = null;
+        String nameString = selector.name.slowToString();
+        if (selector.isGetter()) {
+          jsName = namer.getterName(selector.library, selector.name);
+          methodName = 'get:$nameString';
+        } else if (selector.isSetter()) {
+          jsName = namer.setterName(selector.library, selector.name);
+          methodName = 'set:$nameString';
+        } else if (selector.isCall()) {
+          jsName = namer.instanceMethodInvocationName(
+              selector.library, selector.name, selector);
+          methodName = nameString;
+        } else {
+          // We simply ignore selectors that do not need
+          // noSuchMethod handlers.
+          continue;
+        }
+
+        if (!addedJsNames.contains(jsName)) {
+          CodeBuffer jsCode = generateMethod(methodName, selector);
+          defineInstanceMember(jsName, jsCode);
+          addedJsNames.add(jsName);
         }
       }
     }
 
     compiler.codegenWorld.invokedNames.forEach(addNoSuchMethodHandlers);
     compiler.codegenWorld.invokedGetters.forEach(addNoSuchMethodHandlers);
     compiler.codegenWorld.invokedSetters.forEach(addNoSuchMethodHandlers);
   }
 
   String buildIsolateSetup(CodeBuffer buffer,
@@ skipping 126 matching lines @@
         sourceName = token.slowToString();
       }
       int totalOffset = bufferOffset + offset;
       sourceMapBuilder.addMapping(
           sourceFile, token.charOffset, sourceName, totalOffset);
     });
   }
 }
 
 typedef void DefineMemberFunction(String invocationName, CodeBuffer definition);