- Split Dart core libraries into shared sources and patch sources.

- Split Dart core libraries into shared sources and patch sources.
  Currently this split goes along the runtime vs. library directories,
  eventually more shared code will be sitting in the shared library
  sources.
Committed: https://code.google.com/p/dart/source/detail?r=10612

[siva, 2012-08-13 18:46:12]

LGTM with one question regarding RegisterPrivateClass

https://chromiumcodereview.appspot.com/10834284/diff/9001/lib/empty_source.dart
File lib/empty_source.dart (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/lib/empty_source.da...
lib/empty_source.dart:5: // THIS FILE INTENTIONALLY LEFT BLANK.
FILE IS INTENT....

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/bootstrap.cc
File vm/bootstrap.cc (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/bootstrap.cc#new...
vm/bootstrap.cc:45: const char* url = patch ? "dart:match-patch" : "dart:math";
math_patch ?

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/bootstrap.h
File vm/bootstrap.h (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/bootstrap.h#newc...
vm/bootstrap.h:32: static const char corelib_patch_[];
I am wondering if this should be called corelib_patch_source_ to be consistent
with the notion of naming these variables *_source_ to indicate they contain
dart source code.

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/object.cc#newcod...
vm/object.cc:448: cls.set_script(script);
Why is it ok to set the script here in the case of private classes?

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/object.h#newcode298
vm/object.h:298: const Library& lib);
We should probably move the two methods RegisterClass and RegisterPrivateClass
as private methods so that we won't have some external code using it and end up
with classes registered in the library and not have a script associated with it.

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/vm.gypi
File vm/vm.gypi (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/vm.gypi#newcode11
vm/vm.gypi:11: 'corelib_impl_patch_cc_file':
'<(SHARED_INTERMEDIATE_DIR)/corelib_impl_patch_gen.cc',
I don't quite understand the need to patch corelib_impl as it is supposed to be
an implementation specific library. As discussed offline we should probably
defer this until the corelib/corelibimpl split is finalized.

[Ivan Posva, 2012-08-13 23:01:17]

https://chromiumcodereview.appspot.com/10834284/diff/9001/lib/empty_source.dart
File lib/empty_source.dart (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/lib/empty_source.da...
lib/empty_source.dart:5: // THIS FILE INTENTIONALLY LEFT BLANK.
On 2012/08/13 18:46:12, asiva wrote:
> FILE IS INTENT....

http://en.wikipedia.org/wiki/Intentionally_blank_page#Classified_documents

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/bootstrap.cc
File vm/bootstrap.cc (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/bootstrap.cc#new...
vm/bootstrap.cc:45: const char* url = patch ? "dart:match-patch" : "dart:math";
On 2012/08/13 18:46:12, asiva wrote:
> math_patch ?

Done.

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/object.cc#newcod...
vm/object.cc:448: cls.set_script(script);
On 2012/08/13 18:46:12, asiva wrote:
> Why is it ok to set the script here in the case of private classes?

Done.

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10834284/diff/9001/vm/object.h#newcode298
vm/object.h:298: const Library& lib);
On 2012/08/13 18:46:12, asiva wrote:
> We should probably move the two methods RegisterClass and RegisterPrivateClass
> as private methods so that we won't have some external code using it and end
up
> with classes registered in the library and not have a script associated with
it.

Done. Same for CreateAndRegisterInterface.