Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: vm/dart_api_impl_test.cc

Issue 10834284: - Split Dart core libraries into shared sources and patch sources. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/bootstrap_nocorelib.cc ('k') | vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl_test.cc
===================================================================
--- vm/dart_api_impl_test.cc (revision 10607)
+++ vm/dart_api_impl_test.cc (working copy)
@@ -5508,15 +5508,19 @@
Dart_Handle result = Dart_SetLibraryTagHandler(library_handler);
EXPECT_VALID(result);
- Dart_Handle lib_url = Dart_NewString("theLibrary");
+ Dart_Handle url = Dart_NewString("theLibrary");
Dart_Handle source = Dart_NewString(kLibraryChars);
- result = Dart_LoadLibrary(lib_url, source);
+ result = Dart_LoadLibrary(url, source);
EXPECT_VALID(result);
- const String& url = String::Handle(String::New("theLibrary"));
+ const String& patch_url = String::Handle(String::New("theLibrary patch"));
const String& patch_source = String::Handle(String::New(kPatchChars));
- const Library& lib = Library::Handle(Library::LookupLibrary(url));
- const Error& err = Error::Handle(lib.Patch(url, patch_source));
+ const Script& patch_script = Script::Handle(Script::New(
+ patch_url, patch_source, RawScript::kPatchTag));
+
+ const String& lib_url = String::Handle(String::New("theLibrary"));
+ const Library& lib = Library::Handle(Library::LookupLibrary(lib_url));
+ const Error& err = Error::Handle(lib.Patch(patch_script));
if (!err.IsNull()) {
OS::Print("Patching error: %s\n", err.ToErrorCString());
EXPECT(false);
« no previous file with comments | « vm/bootstrap_nocorelib.cc ('k') | vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698