Issue 10834271: Support typed arrays constructor templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834271: Support typed arrays constructor templates. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support typed arrays constructor templates. TBR=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=10501

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -14 lines)			Patch
	M	lib/dom/scripts/systemnative.py	View		2 chunks	+27 lines, -2 lines	2 comments	Download
	M	tests/html/html.status	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://chromiumcodereview.appspot.com/10834271/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10834271/diff/1/lib/dom/scripts/systemnative.py#newcode296 lib/dom/scripts/systemnative.py:296: ATTRIBUTES_OF_CONSTRUCTABLE = set([ Please move to the top ...

8 years, 4 months ago (2012-08-21 12:36:27 UTC) #3

Anton Muhin

8 years, 4 months ago (2012-08-21 18:15:55 UTC) #4

https://chromiumcodereview.appspot.com/10834271/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10834271/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:296: ATTRIBUTES_OF_CONSTRUCTABLE = set([
On 2012/08/21 12:36:27, podivilov wrote:
> Please move to the top of the file.

I am somewhat concerned with moving it far away from the only usage.  Maybe
instead move into the method itself?

Expand Messages | Collapse Messages