Support typed arrays constructor templates.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 227 matching lines @@
 
     ext_attrs = self._interface.ext_attrs
 
     if 'CustomConstructor' in ext_attrs:
       # We have a custom implementation for it.
       self._cpp_declarations_emitter.Emit(
           '\n'
           'void constructorCallback(Dart_NativeArguments);\n')
       return
 
+    if ext_attrs.get('ConstructorTemplate') == 'TypedArray':
+      self._cpp_impl_includes.add('"DartArrayBufferViewCustom.h"');
+      self._cpp_definitions_emitter.Emit(
+        '\n'
+        'static void constructorCallback(Dart_NativeArguments args)\n'
+        '{\n'
+        '    WebCore::DartArrayBufferViewInternal::constructWebGLArray<Dart$(INTERFACE_NAME)>(args);\n'
+        '}\n',
+        INTERFACE_NAME=self._interface.id);
+      return
+
     create_function = 'create'
     if 'NamedConstructor' in ext_attrs:
       create_function = 'createForJSConstructor'
     function_expression = '%s::%s' % (self._interface_type_info.native_type(), create_function)
     self._GenerateNativeCallback(
         'constructorCallback',
         False,
         function_expression,
         self._interface,
         constructor_info.idl_args,
@@ skipping 17 matching lines @@
     # FIXME: We're currently injecting List<..> and EventTarget as
     # supertypes in dart.idl. We should annotate/preserve as
     # attributes instead.  For now, this hack lets the self._interfaces
     # inherit, but not the classes.
     # List methods are injected in AddIndexer.
     if IsDartListType(supertype) or IsDartCollectionType(supertype):
       return root_class
 
     return self._ImplClassName(supertype)
 
+  ATTRIBUTES_OF_CONSTRUCTABLE = set([

[podivilov, 2012/08/21 12:36:27]

Please move to the top of the file.

[Anton Muhin, 2012/08/21 18:15:55]

I am somewhat concerned with moving it far away from the only usage.  Maybe
instead move into the method itself?

+    'CustomConstructor',
+    'V8CustomConstructor',
+    'Constructor',
+    'NamedConstructor'])
+
   def _IsConstructable(self):
-    # FIXME: support ConstructorTemplate.
-    return set(['CustomConstructor', 'V8CustomConstructor', 'Constructor', 'NamedConstructor']) & set(self._interface.ext_attrs)
+    ext_attrs = self._interface.ext_attrs
+
+    if self.ATTRIBUTES_OF_CONSTRUCTABLE & set(ext_attrs):
+      return True
+
+    # FIXME: support other types of ConstructorTemplate.
+    if ext_attrs.get('ConstructorTemplate') == 'TypedArray':
+      return True
+
+    return False
 
   def EmitFactoryProvider(self, constructor_info, factory_provider, emitter):
     template_file = 'factoryprovider_%s.darttemplate' % self._html_interface_name
     template = self._system._templates.TryLoad(template_file)
     if not template:
       template = self._system._templates.Load('factoryprovider.darttemplate')
 
     native_binding = '%s_constructor_Callback' % self._interface.id
     emitter.Emit(
         template,
@@ skipping 613 matching lines @@
     parent_interface = _FindInHierarchy(database, parent_interface, test)
     if parent_interface:
       return parent_interface
 
 def _ToWebKitName(name):
   name = name[0].lower() + name[1:]
   name = re.sub(r'^(hTML|uRL|jS|xML|xSLT)', lambda s: s.group(1).lower(),
                 name)
   return re.sub(r'^(create|exclusive)', lambda s: 'is' + s.group(1).capitalize(),
                 name)