Issue 10832321: Issue 4048. Support for revised library/import syntax

Issue 10832321: Issue 4048. Support for revised library/import syntax (Closed)

Created:
8 years, 4 months ago by scheglov

Modified:
8 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 4048. Support for revised library/import syntax http://code.google.com/p/dart/issues/detail?id=4048 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10775

Patch Set 1 #

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+412 lines, -73 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartImportDirective.java	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/LibraryImport.java	View	2 chunks	+58 lines, -6 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/LibraryNode.java	View	4 chunks	+22 lines, -4 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/ast/LibraryUnit.java	View	11 chunks	+26 lines, -20 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Elements.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/LibraryElement.java	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/resolver/LibraryElementImplementation.java	View	2 chunks	+11 lines, -0 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/resolver/Scope.java	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java	View	3 chunks	+76 lines, -35 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View	2 chunks	+173 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 4 months ago (2012-08-15 21:45:58 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10832321/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/ast/LibraryNode.java (right):

https://chromiumcodereview.appspot.com/10832321/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/ast/LibraryNode.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10832321/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/LibraryElement.java
(right):

https://chromiumcodereview.appspot.com/10832321/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/LibraryElement.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10832321/diff/1/compiler/java/com/goog...
File
compiler/java/com/google/dart/compiler/resolver/LibraryElementImplementation.java
(right):

https://chromiumcodereview.appspot.com/10832321/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/LibraryElementImplementation.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

Expand Messages | Collapse Messages