Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

Issue 10832321: Issue 4048. Support for revised library/import syntax (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« compiler/java/com/google/dart/compiler/resolver/LibraryElementImplementation.java ('K') | « compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
index 35e76b3c1a325526729f1247a3b3c9f028875cec..eab4a20b1e0c4209aa46e8642597c923bc341e47 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
@@ -838,7 +838,7 @@ public class IncrementalCompilation2Test extends CompilerTestCase {
APP,
makeCode(
"// filler filler filler filler filler filler filler filler filler filler filler",
- "library applicatioN;",
+ "library application;",
"import 'A.dart' as lib;",
"class A {",
" factory lib.I() {}",
@@ -878,6 +878,178 @@ public class IncrementalCompilation2Test extends CompilerTestCase {
/**
* <p>
+ * http://code.google.com/p/dart/issues/detail?id=3340
+ */
+ public void test_useImportPrefix_asTopLevelFieldName() throws Exception {
+ appSource.setContent(
+ "A.dart",
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library A;",
+ ""));
+ appSource.setContent(
+ APP,
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library application;",
+ "import 'A.dart' as prf;",
+ "var prf;",
+ "main() {",
+ "}",
+ ""));
+ // do compile, no errors expected
+ compile();
+ assertErrors(errors, errEx(ResolverErrorCode.CANNOT_HIDE_IMPORT_PREFIX, 4, 5, 3));
+ }
+
+ public void test_newLibrarySyntax_show() throws Exception {
+ appSource.setContent(
+ "A.dart",
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.A;",
+ "class TypeA {}",
+ "class TypeB {}",
+ "class TypeC {}",
+ ""));
+ appSource.setContent(
+ APP,
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.app;",
+ "import 'A.dart' as libA show TypeA, TypeB;",
+ "main() {",
+ " libA.TypeA v1;",
+ " libA.TypeB v2;",
+ " libA.TypeC v3;",
+ "}",
+ ""));
+ // TypeC not listed in "show"
+ compile();
+ assertErrors(errors, errEx(TypeErrorCode.NO_SUCH_TYPE, 7, 3, 10));
+ }
+
+ public void test_newLibrarySyntax_hide() throws Exception {
+ appSource.setContent(
+ "A.dart",
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.A;",
+ "class TypeA {}",
+ "class TypeB {}",
+ "class TypeC {}",
+ ""));
+ appSource.setContent(
+ APP,
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.app;",
+ "import 'A.dart' as libA hide TypeC;",
+ "main() {",
+ " libA.TypeA v1;",
+ " libA.TypeB v2;",
+ " libA.TypeC v3;",
+ "}",
+ ""));
+ // TypeC is listed in "hide"
+ compile();
+ assertErrors(errors, errEx(TypeErrorCode.NO_SUCH_TYPE, 7, 3, 10));
+ }
+
+ public void test_newLibrarySyntax_export() throws Exception {
+ appSource.setContent(
+ "A.dart",
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.A;",
+ "class TypeAA {}",
+ "class TypeAB {}",
+ "class TypeAC {}",
+ ""));
+ appSource.setContent(
+ "B.dart",
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.B;",
+ "import 'A.dart' as libA hide TypeAC & export;",
+ "class TypeBA {}",
+ "class TypeBB {}",
+ "class TypeBC {}",
+ ""));
+ appSource.setContent(
+ APP,
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.app;",
+ "import 'B.dart' as libB hide TypeAA, TypeBB;",
+ "main() {",
+ " libB.TypeAA aa;",
+ " libB.TypeAB ab;",
+ " libB.TypeAC ac;",
+ " libB.TypeBA ba;",
+ " libB.TypeBB bb;",
+ " libB.TypeBC bc;",
+ "}",
+ ""));
+ compile();
+ assertErrors(
+ errors,
+ errEx(TypeErrorCode.NO_SUCH_TYPE, 5, 3, 11),
+ errEx(TypeErrorCode.NO_SUCH_TYPE, 7, 3, 11),
+ errEx(TypeErrorCode.NO_SUCH_TYPE, 9, 3, 11));
+ assertTrue(errors.toString().contains("libB.TypeAA"));
+ assertTrue(errors.toString().contains("libB.TypeAC"));
+ assertTrue(errors.toString().contains("libB.TypeBB"));
+ }
+
+ public void test_newLibrarySyntax_noExport() throws Exception {
+ appSource.setContent(
+ "A.dart",
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.A;",
+ "class TypeAA {}",
+ "class TypeAB {}",
+ "class TypeAC {}",
+ ""));
+ appSource.setContent(
+ "B.dart",
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.B;",
+ "import 'A.dart' as libA;",
+ "class TypeBA {}",
+ "class TypeBB {}",
+ "class TypeBC {}",
+ ""));
+ appSource.setContent(
+ APP,
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler filler",
+ "library test.app;",
+ "import 'B.dart' as libB;",
+ "main() {",
+ " libB.TypeAA aa;",
+ " libB.TypeAB ab;",
+ " libB.TypeAC ac;",
+ " libB.TypeBA ba;",
+ " libB.TypeBB bb;",
+ " libB.TypeBC bc;",
+ "}",
+ ""));
+ compile();
+ assertErrors(
+ errors,
+ errEx(TypeErrorCode.NO_SUCH_TYPE, 5, 3, 11),
+ errEx(TypeErrorCode.NO_SUCH_TYPE, 6, 3, 11),
+ errEx(TypeErrorCode.NO_SUCH_TYPE, 7, 3, 11));
+ assertTrue(errors.toString().contains("libB.TypeAA"));
+ assertTrue(errors.toString().contains("libB.TypeAB"));
+ assertTrue(errors.toString().contains("libB.TypeAC"));
+ }
+
+ /**
+ * <p>
* http://code.google.com/p/dart/issues/detail?id=4238
*/
public void test_typesPropagation_html_query() throws Exception {
« compiler/java/com/google/dart/compiler/resolver/LibraryElementImplementation.java ('K') | « compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698