Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10832144: Fixed several compiler warnings. (Closed)

Created:
8 years, 4 months ago by devoncarew
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixed several compiler warnings. Committed: https://code.google.com/p/dart/source/detail?r=10256

Patch Set 1 #

Total comments: 10

Messages

Total messages: 6 (0 generated)
devoncarew
8 years, 4 months ago (2012-08-03 21:20:23 UTC) #1
pquitslund
LGTM % nits. http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.google.dart.indexer/src/com/google/dart/indexer/index/readonly/DiskBackedIndexImpl.java File editor/tools/plugins/com.google.dart.indexer/src/com/google/dart/indexer/index/readonly/DiskBackedIndexImpl.java (right): http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.google.dart.indexer/src/com/google/dart/indexer/index/readonly/DiskBackedIndexImpl.java#newcode2 editor/tools/plugins/com.google.dart.indexer/src/com/google/dart/indexer/index/readonly/DiskBackedIndexImpl.java:2: * Copyright (c) 2011, the Dart ...
8 years, 4 months ago (2012-08-03 21:31:01 UTC) #2
devoncarew
http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.google.dart.indexer/src/com/google/dart/indexer/index/readonly/DiskBackedIndexImpl.java File editor/tools/plugins/com.google.dart.indexer/src/com/google/dart/indexer/index/readonly/DiskBackedIndexImpl.java (right): http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.google.dart.indexer/src/com/google/dart/indexer/index/readonly/DiskBackedIndexImpl.java#newcode2 editor/tools/plugins/com.google.dart.indexer/src/com/google/dart/indexer/index/readonly/DiskBackedIndexImpl.java:2: * Copyright (c) 2011, the Dart project authors. On ...
8 years, 4 months ago (2012-08-03 21:37:43 UTC) #3
Brian Wilkerson
LGTM http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode499 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:499: // /** I know about this, and I'd ...
8 years, 4 months ago (2012-08-03 21:41:21 UTC) #4
devoncarew
http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode499 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:499: // /** On 2012/08/03 21:41:21, Brian Wilkerson wrote: > ...
8 years, 4 months ago (2012-08-03 21:43:23 UTC) #5
Brian Wilkerson
8 years, 4 months ago (2012-08-03 21:59:46 UTC) #6 
Still LGTM

http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java
(right):

http://codereview.chromium.org/10832144/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:499:
//  /**
Either way, or no change at all. I'll be fixing it relatively soon by using it.

Powered by Google App Engine
This is Rietveld 408576698