Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

Issue 10832144: Fixed several compiler warnings. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java
===================================================================
--- editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (revision 10251)
+++ editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (working copy)
@@ -496,18 +496,18 @@
return true;
}
- /**
- * Return {@code true} if the current token is a valid identifier. Valid identifiers include
- * built-in identifiers (pseudo-keywords).
- *
- * @return {@code true} if the current token is a valid identifier
- */
- private boolean matchesIdentifier() {
- // TODO(brianwilkerson) Use this in most of the places where matches(TokenType.IDENTIFIER) is
- // currently being used.
- return matches(TokenType.IDENTIFIER)
- || (matches(TokenType.KEYWORD) && ((KeywordToken) currentToken).getKeyword().isPseudoKeyword());
- }
+// /**
Brian Wilkerson 2012/08/03 21:41:21 I know about this, and I'd rather that it didn't g
devoncarew 2012/08/03 21:43:23 @SuppressWarnings("unused")?
Brian Wilkerson 2012/08/03 21:59:46 Either way, or no change at all. I'll be fixing it
+// * Return {@code true} if the current token is a valid identifier. Valid identifiers include
+// * built-in identifiers (pseudo-keywords).
+// *
+// * @return {@code true} if the current token is a valid identifier
+// */
+// private boolean matchesIdentifier() {
+// // TODO(brianwilkerson) Use this in most of the places where matches(TokenType.IDENTIFIER) is
+// // currently being used.
+// return matches(TokenType.IDENTIFIER)
+// || (matches(TokenType.KEYWORD) && ((KeywordToken) currentToken).getKeyword().isPseudoKeyword());
+// }
/**
* If the current token has the given type, then advance to the next token and return {@code true}

Powered by Google App Engine
This is Rietveld 408576698