Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 10832129: Get back recording 'implements' and 'extends' keyword on NodeList (Closed)

Created:
8 years, 4 months ago by Roman
Modified:
8 years, 4 months ago
Reviewers:
Anton Muhin, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get back recording 'implements' and 'extends' keyword on NodeList as suggested by Peter in https://chromiumcodereview.appspot.com/10786028/ Committed: https://code.google.com/p/dart/source/detail?r=10214

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -36 lines) Patch
M lib/compiler/implementation/dart_backend/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/listener.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M lib/compiler/implementation/tree/unparser.dart View 1 2 10 chunks +23 lines, -32 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Roman
8 years, 4 months ago (2012-08-03 06:29:51 UTC) #1
ahe
LGTM! https://chromiumcodereview.appspot.com/10832129/diff/2001/lib/compiler/implementation/tree/unparser.dart File lib/compiler/implementation/tree/unparser.dart (right): https://chromiumcodereview.appspot.com/10832129/diff/2001/lib/compiler/implementation/tree/unparser.dart#newcode129 lib/compiler/implementation/tree/unparser.dart:129: add(node.token.value); Long term, consider if this is simpler ...
8 years, 4 months ago (2012-08-03 06:46:43 UTC) #2
Roman
8 years, 4 months ago (2012-08-03 08:02:19 UTC) #3
https://chromiumcodereview.appspot.com/10832129/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10832129/diff/2001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:176: // TODO(ahe): handle
'const'.
On 2012/08/03 06:46:43, ahe wrote:
> Is this TODO obsolete?

I guess so. Removed.

Powered by Google App Engine
This is Rietveld 408576698