Issue 10831248: 1. Write out only the kind_tag_ field of a function in the snapshot instead of the individual bits …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831248: 1. Write out only the kind_tag_ field of a function in the snapshot instead of the individual bits … (Closed)

Created:
8 years, 4 months ago by siva

Modified:
8 years, 4 months ago

Reviewers:
turnidge, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

1. Write out only the kind_tag_ field of a function in the snapshot instead of the individual bits as boolean values. This reduces the snapshot size by about 4k 2. Move the kind_tag_ accessor functions from RawFunction to Function (we try not to have any code in the Raw classes). Committed: https://code.google.com/p/dart/source/detail?r=10528

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -105 lines)			Patch
M	vm/object.h	View	4 chunks	+36 lines, -8 lines	0 comments	Download
M	vm/object.cc	View	3 chunks	+21 lines, -8 lines	0 comments	Download
M	vm/raw_object.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View	2 chunks	+2 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

turnidge

8 years, 4 months ago (2012-08-10 03:49:02 UTC) #2

lgtm

Moving the KindBits from RawFunction to Function seems fine.  I'm wondering why
we don't move the TagBits from RawObject to Object too.

Expand Messages | Collapse Messages