Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: vm/raw_object_snapshot.cc

Issue 10831248: 1. Write out only the kind_tag_ field of a function in the snapshot instead of the individual bits … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/raw_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/raw_object_snapshot.cc
===================================================================
--- vm/raw_object_snapshot.cc (revision 10450)
+++ vm/raw_object_snapshot.cc (working copy)
@@ -433,12 +433,7 @@
func.set_num_optional_parameters(reader->ReadIntptrValue());
func.set_usage_counter(reader->ReadIntptrValue());
func.set_deoptimization_counter(reader->ReadIntptrValue());
- func.set_kind(static_cast<RawFunction::Kind >(reader->ReadIntptrValue()));
- func.set_is_static(reader->Read<bool>());
- func.set_is_const(reader->Read<bool>());
- func.set_is_optimizable(reader->Read<bool>());
- func.set_is_native(reader->Read<bool>());
- func.set_is_abstract(reader->Read<bool>());
+ func.set_kind_tag(reader->ReadIntptrValue());
// Set all the object fields.
// TODO(5411462): Need to assert No GC can happen here, even though
@@ -473,12 +468,7 @@
writer->WriteIntptrValue(ptr()->num_optional_parameters_);
writer->WriteIntptrValue(ptr()->usage_counter_);
writer->WriteIntptrValue(ptr()->deoptimization_counter_);
- writer->WriteIntptrValue(GetKind());
- writer->Write<bool>(IsStatic());
- writer->Write<bool>(IsConst());
- writer->Write<bool>(IsOptimizable());
- writer->Write<bool>(IsNative());
- writer->Write<bool>(IsAbstract());
+ writer->WriteIntptrValue(ptr()->kind_tag_);
// Write out all the object pointer fields.
SnapshotWriterVisitor visitor(writer);
« no previous file with comments | « vm/raw_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698