Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 10830154: Allow NULL classes in inline caches (for example for ==). Fixes a 22x regression with r9762 on a be… (Closed)

Created:
8 years, 4 months ago by srdjan
Modified:
8 years, 4 months ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, rmacnak
Visibility:
Public.

Description

Allow NULL classes in inline caches (for example for ==). Fixes a 22x regression with r9762 on a benchmark provided by Ryan. Committed: https://code.google.com/p/dart/source/detail?r=10206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
8 years, 4 months ago (2012-08-03 00:07:42 UTC) #1
srdjan
8 years, 4 months ago (2012-08-03 00:13:13 UTC) #2
srdjan
8 years, 4 months ago (2012-08-03 00:20:24 UTC) #3
siva
lgtm
8 years, 4 months ago (2012-08-03 00:22:52 UTC) #4
hausner
8 years, 4 months ago (2012-08-03 00:24:20 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698