Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: runtime/vm/code_generator.cc

Issue 10830154: Allow NULL classes in inline caches (for example for ==). Fixes a 22x regression with r9762 on a be… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 10202)
+++ runtime/vm/code_generator.cc (working copy)
@@ -874,17 +874,6 @@
const Function& target_function =
Function::Handle(target_code.function());
ASSERT(!target_function.IsNull());
- if (receiver.IsNull()) {
- // Null dispatch is slow (e.g., (null).toCString()). The only
- // fast execution with null receiver is the "==" operator.
- // Special handling so that we do not pollute the inline cache with null
- // classes.
- if (FLAG_trace_ic) {
- OS::Print("InlineCacheMissHandler Null receiver target %s\n",
- target_function.ToCString());
- }
- return target_function.raw();
- }
DartFrameIterator iterator;
StackFrame* caller_frame = iterator.NextFrame();
ASSERT(caller_frame != NULL);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698