Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 10829442: Rename i18n to intl (Closed)

Created:
8 years, 4 months ago by Alan Knight
Modified:
8 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12596 lines) Patch
D pkg/i18n/bidi_formatter.dart View 1 chunk +0 lines, -180 lines 0 comments Download
D pkg/i18n/bidi_utils.dart View 1 chunk +0 lines, -391 lines 0 comments Download
D pkg/i18n/date_format.dart View 1 chunk +0 lines, -530 lines 0 comments Download
D pkg/i18n/date_symbol_data.dart View 1 chunk +0 lines, -3548 lines 0 comments Download
D pkg/i18n/date_symbols.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D pkg/i18n/date_time_patterns.dart View 1 chunk +0 lines, -3964 lines 0 comments Download
D pkg/i18n/intl.dart View 1 chunk +0 lines, -188 lines 0 comments Download
D pkg/i18n/intl_message.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D pkg/i18n/lib/date_format_field.dart View 1 chunk +0 lines, -402 lines 0 comments Download
D pkg/i18n/number_format.dart View 1 chunk +0 lines, -270 lines 0 comments Download
D pkg/i18n/number_symbols.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/i18n/number_symbols_data.dart View 1 chunk +0 lines, -1601 lines 0 comments Download
D pkg/i18n/pubspec.yaml View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/i18n/test/bidi_format_test.dart View 1 chunk +0 lines, -211 lines 0 comments Download
D pkg/i18n/test/bidi_utils_test.dart View 1 chunk +0 lines, -346 lines 0 comments Download
D pkg/i18n/test/date_time_format_test.dart View 1 chunk +0 lines, -294 lines 0 comments Download
D pkg/i18n/test/date_time_format_test_data.dart View 1 chunk +0 lines, -334 lines 0 comments Download
D pkg/i18n/test/intl_message_test.dart View 1 chunk +0 lines, -86 lines 0 comments Download
D pkg/i18n/test/intl_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/i18n/test/number_format_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
M + pkg/intl/lib/date_format_field.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M + pkg/intl/lib/date_format_helpers.dart View 1 1 chunk +5 lines, -8 lines 0 comments Download
M + pkg/intl/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 3 chunks +5 lines, -3 lines 2 comments Download
M utils/apidoc/apidoc.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alan Knight
In addition to the obvious move this has changes to build (of api docs) and ...
8 years, 4 months ago (2012-08-20 21:52:39 UTC) #1
Emily Fortuna
I'm assuming it's a bug on the code review tool that it's only showing deleting ...
8 years, 4 months ago (2012-08-20 22:08:24 UTC) #2
Alan Knight
Changed the regular expression and put in some minor error handling for when it fails. ...
8 years, 4 months ago (2012-08-20 23:41:43 UTC) #3
Emily Fortuna
https://chromiumcodereview.appspot.com/10829442/diff/2002/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10829442/diff/2002/tools/create_sdk.py#newcode425 tools/create_sdk.py:425: copytree(join(src_dir, 'lib'), join(dest_dir, 'lib')) what are these lines for?
8 years, 4 months ago (2012-08-21 00:47:47 UTC) #4
Alan Knight
https://chromiumcodereview.appspot.com/10829442/diff/2002/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10829442/diff/2002/tools/create_sdk.py#newcode425 tools/create_sdk.py:425: copytree(join(src_dir, 'lib'), join(dest_dir, 'lib')) On 2012/08/21 00:47:47, Emily Fortuna ...
8 years, 4 months ago (2012-08-21 04:49:55 UTC) #5
Emily Fortuna
8 years, 4 months ago (2012-08-21 17:17:35 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698