Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 10829365: Issue 4553. Any constant is valid for 'case'. (Closed)

Created:
8 years, 4 months ago by scheglov
Modified:
8 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 4553. Any constant is valid for 'case'. Also check for 'operator =='. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -16 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java View 2 chunks +7 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java View 2 chunks +7 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 3 chunks +8 lines, -6 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 2 chunks +57 lines, -4 lines 0 comments Download
M tests/co19/co19-compiler.status View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/pub/pub.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 4 months ago (2012-08-16 23:46:05 UTC) #1
Brian Wilkerson
8 years, 4 months ago (2012-08-17 14:03:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698