compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java - Issue 10829365: Issue 4553. Any constant is valid for 'case'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

Issue 10829365: Issue 4553. Any constant is valid for 'case'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java ('k') | compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

index 96df0a2d78c182ecadb8482a661a59fbb4df839f..e837b426a8b4e5e8ef00ebbdab4987de4ff48a65 100644

--- a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

@@ -7,6 +7,7 @@ package com.google.dart.compiler.resolver;

import com.google.common.annotations.VisibleForTesting;

import com.google.dart.compiler.DartCompilerContext;

import com.google.dart.compiler.ast.DartBlock;

+import com.google.dart.compiler.ast.DartCase;

import com.google.dart.compiler.ast.DartClass;

import com.google.dart.compiler.ast.DartExpression;

import com.google.dart.compiler.ast.DartField;

@@ -210,6 +211,12 @@ public class CompileTimeConstantResolver {

}

return null;

}

+ @Override

+ public Element visitCase(DartCase node) {

+ resolveConstantExpression(node.getExpr());

+ return super.visitCase(node);

+ }

@Override

public Element visitNewExpression(DartNewExpression node) {