Issue 10829164: Replace InstanceSetterComp instruction with a plain instance call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829164: Replace InstanceSetterComp instruction with a plain instance call. (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Replace InstanceSetterComp instruction with a plain instance call. After my last change to InstanceSetterComp we do not need a separate IL instruction for it anymore. Committed: https://code.google.com/p/dart/source/detail?r=10278

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -201 lines)			Patch
M	vm/flow_graph_builder.cc	View	2 chunks	+19 lines, -10 lines	0 comments	Download
M	vm/flow_graph_optimizer.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	vm/flow_graph_optimizer.cc	View	4 chunks	+13 lines, -18 lines	0 comments	Download
M	vm/il_printer.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	vm/intermediate_language.h	View	6 chunks	+4 lines, -41 lines	0 comments	Download
M	vm/intermediate_language.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	vm/intermediate_language_ia32.cc	View	1 chunk	+0 lines, -57 lines	0 comments	Download
M	vm/intermediate_language_x64.cc	View	1 chunk	+0 lines, -57 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages