Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: vm/intermediate_language_ia32.cc

Issue 10829164: Replace InstanceSetterComp instruction with a plain instance call. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/intermediate_language.cc ('k') | vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/intermediate_language_ia32.cc
===================================================================
--- vm/intermediate_language_ia32.cc (revision 10227)
+++ vm/intermediate_language_ia32.cc (working copy)
@@ -949,63 +949,6 @@
}
-LocationSummary* InstanceSetterComp::MakeLocationSummary() const {
- return MakeCallSummary();
-}
-
-
-void InstanceSetterComp::EmitNativeCode(FlowGraphCompiler* compiler) {
- Label* deopt = NULL;
- if (compiler->is_optimizing()) {
- deopt = compiler->AddDeoptStub(cid(),
- token_pos(),
- try_index(),
- kDeoptInstanceSetter);
- }
- if (HasICData() && (ic_data()->NumberOfChecks() > 0)) {
- // No index-setter on Smi's.
- ASSERT(ic_data()->GetReceiverClassIdAt(0) != kSmi);
- // Load receiver into EAX.
- const intptr_t kNumArguments = 2;
- __ movl(EAX, Address(ESP, (kNumArguments - 1) * kWordSize));
- __ testl(EAX, Immediate(kSmiTagMask));
- __ j(ZERO, deopt);
- __ LoadClassId(EDI, EAX);
- compiler->EmitTestAndCall(*ic_data(),
- EDI, // Class id register.
- kNumArguments,
- Array::Handle(), // No named arguments.
- deopt, // Deoptimize target.
- NULL, // Fallthrough when done.
- cid(),
- token_pos(),
- try_index());
-
- } else if (compiler->is_optimizing()) {
- // Get some IC data then optimize again.
- __ jmp(deopt);
- } else {
- // Unoptimized code.
- const String& function_name =
- String::ZoneHandle(Field::SetterSymbol(field_name()));
-
- compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
- cid(),
- token_pos(),
- try_index());
- const intptr_t kArgumentCount = 2;
- const intptr_t kCheckedArgumentCount = 1;
- compiler->GenerateInstanceCall(cid(),
- token_pos(),
- try_index(),
- function_name,
- kArgumentCount,
- Array::ZoneHandle(),
- kCheckedArgumentCount);
- }
-}
-
-
LocationSummary* LoadInstanceFieldComp::MakeLocationSummary() const {
// TODO(fschneider): For this instruction the input register may be
// reused for the result (but is not required to) because the input
« no previous file with comments | « vm/intermediate_language.cc ('k') | vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698