Issue 10829153: The null tests that I added for Dart_NewString{8,16,32} were too restrictive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829153: The null tests that I added for Dart_NewString{8,16,32} were too restrictive. (Closed)

Created:
8 years, 4 months ago by turnidge

Modified:
8 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anton Muhin

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

The null tests that I added for Dart_NewString{8,16,32} were too restrictive. It is okay to pass NULL codepoints if the length is zero. This should fix the issue we were seeing in dartium. Committed: https://code.google.com/p/dart/source/detail?r=10204

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	vm/dart_api_impl.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
	M	vm/dart_api_impl_test.cc	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM -ip

Expand Messages | Collapse Messages