vm/dart_api_impl.cc - Issue 10829153: The null tests that I added for Dart_NewString{8,16,32} were too restrictive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/dart_api_impl.cc

Issue 10829153: The null tests that I added for Dart_NewString{8,16,32} were too restrictive. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/dart_api_impl.cc

===================================================================

--- vm/dart_api_impl.cc (revision 10203)

+++ vm/dart_api_impl.cc (working copy)

@@ -1590,7 +1590,7 @@

intptr_t length) {

Isolate* isolate = Isolate::Current();

DARTSCOPE(isolate);

- if (codepoints == NULL) {

+ if (codepoints == NULL && length != 0) {

RETURN_NULL_ERROR(codepoints);

}

CHECK_LENGTH(length, String::kMaxElements);

@@ -1602,7 +1602,7 @@

intptr_t length) {

Isolate* isolate = Isolate::Current();

DARTSCOPE(isolate);

- if (codepoints == NULL) {

+ if (codepoints == NULL && length != 0) {

RETURN_NULL_ERROR(codepoints);

}

CHECK_LENGTH(length, String::kMaxElements);

@@ -1614,7 +1614,7 @@

intptr_t length) {

Isolate* isolate = Isolate::Current();

DARTSCOPE(isolate);

- if (codepoints == NULL) {

+ if (codepoints == NULL && length != 0) {

RETURN_NULL_ERROR(codepoints);

}

CHECK_LENGTH(length, String::kMaxElements);

« no previous file with comments | « no previous file | vm/dart_api_impl_test.cc » ('j') | no next file with comments »