Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828411: Re-apply 'Unify dart:isolate.' with fixes for autogenerated dart2js and dartium html files. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-apply 'Unify dart:isolate.' with fixes for autogenerated dart2js and dartium html files. Old Review URL: https://chromiumcodereview.appspot.com//10828410 BUG= Committed: https://code.google.com/p/dart/source/detail?r=11084

Patch Set 1 #

Patch Set 2 : Create a shared js_isolate_impl for html/dartium to use. #

Patch Set 3 : Rebased and fixed an error. #

Total comments: 3

Patch Set 4 : Compiler changes was pulled out and added in a seperate changed. #

Patch Set 5 : Review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+601 lines, -1681 lines) Patch
M lib/_internal/libraries.dart View 1 chunk +1 line, -2 lines 0 comments Download
A + lib/compiler/implementation/lib/isolate_patch.dart View 1 2 4 chunks +524 lines, -3 lines 0 comments Download
M lib/compiler/implementation/library_map.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/config/import_any.config View 1 chunk +1 line, -1 line 0 comments Download
M lib/config/import_dartium.config View 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_vm.config View 1 chunk +0 lines, -1 line 0 comments Download
M lib/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 2 chunks +7 lines, -0 lines 0 comments Download
A + lib/isolate/base.dart View 4 chunks +7 lines, -7 lines 0 comments Download
D lib/isolate/dart2js/compiler_hooks.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D lib/isolate/dart2js/isolateimpl.dart View 1 chunk +0 lines, -545 lines 0 comments Download
D lib/isolate/dart2js/messages.dart View 1 chunk +0 lines, -164 lines 0 comments Download
D lib/isolate/dart2js/ports.dart View 1 chunk +0 lines, -253 lines 0 comments Download
D lib/isolate/dart2js/timer_provider.dart View 1 chunk +0 lines, -45 lines 0 comments Download
A + lib/isolate/isolate.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D lib/isolate/isolate_api.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D lib/isolate/isolate_compiler.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D lib/isolate/isolate_dart2js.dart View 1 chunk +0 lines, -62 lines 0 comments Download
M lib/isolate/isolate_sources.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
D lib/isolate/serialization.dart View 1 2 1 chunk +0 lines, -206 lines 0 comments Download
M lib/isolate/timer.dart View 1 chunk +31 lines, -0 lines 0 comments Download
D lib/isolate/timer_hook.dart View 1 chunk +0 lines, -32 lines 0 comments Download
A + lib/js_isolate_impl/isolate.dart View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
D runtime/lib/isolate.dart View 1 chunk +0 lines, -130 lines 0 comments Download
A + runtime/lib/isolate_patch.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M runtime/lib/isolate_sources.gypi View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
Peter: There is a small change in the compiler. Feel free to poke me at ...
8 years, 4 months ago (2012-08-21 10:24:16 UTC) #1
Mads Ager (google)
LGTM I haven't looked at the compiler change.
8 years, 4 months ago (2012-08-21 10:31:53 UTC) #2
ahe
Please submit compiler changes separately from library changes.
8 years, 4 months ago (2012-08-21 10:56:45 UTC) #3
Anton Muhin
LGTM https://chromiumcodereview.appspot.com/10828411/diff/10001/lib/dom/templates/html/dart2js/html_dart2js.darttemplate File lib/dom/templates/html/dart2js/html_dart2js.darttemplate (right): https://chromiumcodereview.appspot.com/10828411/diff/10001/lib/dom/templates/html/dart2js/html_dart2js.darttemplate#newcode34 lib/dom/templates/html/dart2js/html_dart2js.darttemplate:34: #source("../../js_isolate_impl/isolate.dart"); nit: please, use single quotes for consistency. ...
8 years, 4 months ago (2012-08-21 17:30:45 UTC) #4
Anders Johnsen
8 years, 4 months ago (2012-08-21 18:41:18 UTC) #5 
Fixed, and pulled out compiler changes. Ty.

https://chromiumcodereview.appspot.com/10828411/diff/10001/lib/dom/templates/...
File lib/dom/templates/html/dart2js/html_dart2js.darttemplate (right):

https://chromiumcodereview.appspot.com/10828411/diff/10001/lib/dom/templates/...
lib/dom/templates/html/dart2js/html_dart2js.darttemplate:34:
#source("../../js_isolate_impl/isolate.dart");
On 2012/08/21 17:30:45, Anton Muhin wrote:
> nit: please, use single quotes for consistency.

Done.

Powered by Google App Engine
This is Rietveld 408576698