Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828410: Unify dart:isolate. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen
Modified:
8 years, 4 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Unify dart:isolate. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11016

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review addresses. #

Patch Set 3 : Fix mapping to dart:isolate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1321 lines, -1674 lines) Patch
M lib/_internal/libraries.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A lib/compiler/implementation/lib/isolate_patch.dart View 1 chunk +1267 lines, -0 lines 0 comments Download
M lib/compiler/implementation/library_map.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/compiler/implementation/native_handler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_any.config View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/config/import_dartium.config View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_vm.config View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + lib/isolate/base.dart View 4 chunks +7 lines, -7 lines 0 comments Download
D lib/isolate/dart2js/compiler_hooks.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D lib/isolate/dart2js/isolateimpl.dart View 1 chunk +0 lines, -545 lines 0 comments Download
D lib/isolate/dart2js/messages.dart View 1 chunk +0 lines, -164 lines 0 comments Download
D lib/isolate/dart2js/ports.dart View 1 chunk +0 lines, -253 lines 0 comments Download
D lib/isolate/dart2js/timer_provider.dart View 1 chunk +0 lines, -45 lines 0 comments Download
A + lib/isolate/isolate.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D lib/isolate/isolate_api.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D lib/isolate/isolate_compiler.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D lib/isolate/isolate_dart2js.dart View 1 chunk +0 lines, -62 lines 0 comments Download
M lib/isolate/isolate_sources.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
D lib/isolate/serialization.dart View 1 chunk +0 lines, -203 lines 0 comments Download
M lib/isolate/timer.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
D lib/isolate/timer_hook.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D runtime/lib/isolate.dart View 1 chunk +0 lines, -130 lines 0 comments Download
A + runtime/lib/isolate_patch.dart View 1 2 chunks +6 lines, -7 lines 0 comments Download
M runtime/lib/isolate_sources.gypi View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Anders Johnsen
8 years, 4 months ago (2012-08-21 07:18:32 UTC) #1
Anders Johnsen
8 years, 4 months ago (2012-08-21 07:18:44 UTC) #2
Mads Ager (google)
LGTM https://chromiumcodereview.appspot.com/10828410/diff/1/lib/isolate/timer.dart File lib/isolate/timer.dart (right): https://chromiumcodereview.appspot.com/10828410/diff/1/lib/isolate/timer.dart#newcode39 lib/isolate/timer.dart:39: void callback(Timer timer)) { Indentation is off here. ...
8 years, 4 months ago (2012-08-21 07:27:57 UTC) #3
Anders Johnsen
PTAL (lib/config/*) https://chromiumcodereview.appspot.com/10828410/diff/1/lib/isolate/timer.dart File lib/isolate/timer.dart (right): https://chromiumcodereview.appspot.com/10828410/diff/1/lib/isolate/timer.dart#newcode39 lib/isolate/timer.dart:39: void callback(Timer timer)) { On 2012/08/21 07:27:57, ...
8 years, 4 months ago (2012-08-21 07:45:04 UTC) #4
Mads Ager (google)
LGTM, thanks
8 years, 4 months ago (2012-08-21 07:48:05 UTC) #5
Anders Johnsen
8 years, 4 months ago (2012-08-21 07:52:41 UTC) #6 
Thank you, landing!

Powered by Google App Engine
This is Rietveld 408576698