Issue 10828286: Do not force checked mode on VM.

Issue 10828286: Do not force checked mode on VM. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Bill Hesse, Roman

CC:
reviews_dartlang.org, Roman

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not force checked mode on VM. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=10635

Patch Set 1 #

Total comments: 4

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -27 lines)			Patch
	M	tests/language/language.status	View		6 chunks	+0 lines, -25 lines	2 comments	Download
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Roman

https://chromiumcodereview.appspot.com/10828286/diff/1/tests/language/language.status File tests/language/language.status (left): https://chromiumcodereview.appspot.com/10828286/diff/1/tests/language/language.status#oldcode194 tests/language/language.status:194: type_variable_bounds_test/01: Fail I don't understand why this test fails ...

8 years, 4 months ago (2012-08-14 08:45:30 UTC) #2

Bill Hesse

LGTM. https://chromiumcodereview.appspot.com/10828286/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10828286/diff/1/tools/testing/dart/test_suite.dart#newcode457 tools/testing/dart/test_suite.dart:457: // TODO(antonm): support checked. Is checked mode being ...

8 years, 4 months ago (2012-08-14 09:21:47 UTC) #3

Anton Muhin

8 years, 4 months ago (2012-08-14 11:47:04 UTC) #4

Thanks a lot for review, guys.  I'll submit and keep on working on dart2dart
support in our test framework.

https://chromiumcodereview.appspot.com/10828286/diff/1/tests/language/languag...
File tests/language/language.status (left):

https://chromiumcodereview.appspot.com/10828286/diff/1/tests/language/languag...
tests/language/language.status:194: type_variable_bounds_test/01: Fail
Neither do I, but dart2dart support in test framework is not ideal yet. I don't
think we'll miss a bug anyway.

On 2012/08/14 08:45:31, Roman wrote:
> I don't understand why this test fails in checked mode and does not fail in
> unchecked.
> This is a negative test, in unchecked mode dart vm executes dart2dart output
> code just fine, so the test should fail, right?
> In checked mode VM correctly identifies the type bound problem, so the test
> should pass.

https://chromiumcodereview.appspot.com/10828286/diff/1/tools/testing/dart/tes...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10828286/diff/1/tools/testing/dart/tes...
tools/testing/dart/test_suite.dart:457: // TODO(antonm): support checked.
I am not sure, so I left it.  I'll investigate today.

On 2012/08/14 09:21:47, Bill Hesse wrote:
> Is checked mode being correctly added by other code somewhere?  Should the
TODO
> be closed?

Expand Messages | Collapse Messages