Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 10828286: Do not force checked mode on VM. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 return commands; 447 return commands;
448 448
449 case 'dart2dart': 449 case 'dart2dart':
450 var compilerArguments = new List.from(args); 450 var compilerArguments = new List.from(args);
451 compilerArguments.add('--output-type=dart'); 451 compilerArguments.add('--output-type=dart');
452 String tempDir = createOutputDirectory(info.filePath, ''); 452 String tempDir = createOutputDirectory(info.filePath, '');
453 compilerArguments.add('--out=$tempDir/out.dart'); 453 compilerArguments.add('--out=$tempDir/out.dart');
454 List<Command> commands = 454 List<Command> commands =
455 <Command>[new Command(shellPath(), compilerArguments)]; 455 <Command>[new Command(shellPath(), compilerArguments)];
456 if (configuration['runtime'] == 'vm') { 456 if (configuration['runtime'] == 'vm') {
457 // TODO(antonm): support checked. 457 // TODO(antonm): support checked.
Bill Hesse 2012/08/14 09:21:47 Is checked mode being correctly added by other cod
Anton Muhin 2012/08/14 11:47:04 I am not sure, so I left it. I'll investigate tod
458 var vmArguments = new List.from(vmOptions); 458 var vmArguments = new List.from(vmOptions);
459 vmArguments.addAll( 459 vmArguments.addAll(['$tempDir/out.dart']);
460 ['--enable_checked_mode', '$tempDir/out.dart']);
461 commands.add(new Command( 460 commands.add(new Command(
462 TestUtils.vmFileName(configuration), 461 TestUtils.vmFileName(configuration),
463 vmArguments)); 462 vmArguments));
464 } else { 463 } else {
465 throw 'Unsupported runtime ${configuration["runtime"]} for dart2dart'; 464 throw 'Unsupported runtime ${configuration["runtime"]} for dart2dart';
466 } 465 }
467 return commands; 466 return commands;
468 467
469 case 'none': 468 case 'none':
470 case 'dartc': 469 case 'dartc':
(...skipping 959 matching lines...) Expand 10 before | Expand all | Expand 10 after
1430 * $noCrash tests are expected to be flaky but not crash 1429 * $noCrash tests are expected to be flaky but not crash
1431 * $pass tests are expected to pass 1430 * $pass tests are expected to pass
1432 * $failOk tests are expected to fail that we won't fix 1431 * $failOk tests are expected to fail that we won't fix
1433 * $fail tests are expected to fail that we should fix 1432 * $fail tests are expected to fail that we should fix
1434 * $crash tests are expected to crash that we should fix 1433 * $crash tests are expected to crash that we should fix
1435 * $timeout tests are allowed to timeout 1434 * $timeout tests are allowed to timeout
1436 """; 1435 """;
1437 print(report); 1436 print(report);
1438 } 1437 }
1439 } 1438 }
OLDNEW
« tests/language/language.status ('K') | « tests/language/language.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698