Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 10828189: Do not silently convert integers to doubles in binary operations. Only when at least one of argumen… (Closed)

Created:
8 years, 4 months ago by srdjan
Modified:
8 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, Florian Schneider
Visibility:
Public.

Description

Do not silently convert integers to doubles in binary operations. Only when at least one of arguments is double can the result be double. Committed: https://code.google.com/p/dart/source/detail?r=10323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A tests/language/double_int_addition_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 4 months ago (2012-08-07 00:24:21 UTC) #1
regis
8 years, 4 months ago (2012-08-07 00:30:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698