runtime/vm/intermediate_language_ia32.cc - Issue 10828189: Do not silently convert integers to doubles in binary operations. Only when at least one of argumen…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10828189: Do not silently convert integers to doubles in binary operations. Only when at least one of argumen… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 10316)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -1757,6 +1757,12 @@

left,

right);

+ // Binary operation of two Smi's produces a Smi not a double.

+ __ movl(temp, left);

+ __ orl(temp, right);

+ __ testl(temp, Immediate(kSmiTagMask));

+ __ j(ZERO, deopt);

compiler->LoadDoubleOrSmiToXmm(XMM0, left, temp, deopt);

compiler->LoadDoubleOrSmiToXmm(XMM1, right, temp, deopt);

« no previous file with comments | « no previous file | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »