Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2245)

Issue 10828169: 'Split && condition' quick assist. (Closed)

Created:
8 years, 4 months ago by scheglov
Modified:
8 years, 4 months ago
Reviewers:
messick
CC:
reviews_dartlang.org
Visibility:
Public.

Description

'Split && condition' quick assist. And clean ups, simplifications for other places. R=messick@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -106 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartIfStatement.java View 2 chunks +16 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 chunk +4 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/Token.java View 1 chunk +11 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java View 2 chunks +2 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/IfCompleter.java View 1 chunk +5 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/SourceRangeUtils.java View 1 chunk +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/SourceRangeFactory.java View 3 chunks +23 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/dom/ASTNodes.java View 2 chunks +12 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java View 4 chunks +66 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/TokenUtils.java View 3 chunks +19 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.java View 2 chunks +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.properties View 2 chunks +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/DartCorrectionProcessor.java View 5 chunks +8 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickAssistProcessor.java View 16 chunks +188 lines, -72 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/correction/QuickAssistProcessorTest.java View 3 chunks +174 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 4 months ago (2012-08-05 17:44:52 UTC) #1
messick
8 years, 4 months ago (2012-08-06 16:18:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698