editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/SourceRangeUtils.java - Issue 10828169: 'Split && condition' quick assist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/SourceRangeUtils.java

Issue 10828169: 'Split && condition' quick assist. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/IfCompleter.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/SourceRangeFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/SourceRangeUtils.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/SourceRangeUtils.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/SourceRangeUtils.java

index bab26267e0e572a141e69bf31f5305199313521a..b5c97c0dcae9d85ef9996fd8e4313344d1d5279a 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/SourceRangeUtils.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/SourceRangeUtils.java

@@ -53,8 +53,13 @@ public class SourceRangeUtils {

* @return <code>true</code> if two given {@link SourceRange}s are intersecting.

public static boolean intersects(SourceRange a, SourceRange b) {

- return contains(a, b.getOffset()) || contains(a, b.getOffset() + b.getLength() - 1)

- || contains(b, a.getOffset());

+ if (getEnd(a) <= b.getOffset()) {

+ return false;

+ }

+ if (a.getOffset() >= getEnd(b)) {

+ return false;

+ }

+ return true;

}

/**