Improve renaming of constructors and factories.

Improve renaming of constructors and factories.

Unfortunately, this implementation is not bug free, see comments
for detailed discussion.

R=smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=10232

[Roman, 2012-08-02 05:44:53]

lgtm

Please add couple of tests if anything new is fixed!

https://chromiumcodereview.appspot.com/10828121/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/renamer.dart (right):

https://chromiumcodereview.appspot.com/10828121/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:101: if
(context.isFunction() && context.cachedNode.name == node) {
Can now (context.isFunction()) be false?

https://chromiumcodereview.appspot.com/10828121/diff/1/lib/compiler/implement...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10828121/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/unparser.dart:104: final newName =
renamer.renameIdentifier(name);
Looks like now renameIdentifier is only used for function names or constructors,
maybe rename the method so it is more clear what is it used for?

[Anton Muhin, 2012-08-03 13:57:57]

https://chromiumcodereview.appspot.com/10828121/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/renamer.dart (right):

https://chromiumcodereview.appspot.com/10828121/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:101: if
(context.isFunction() && context.cachedNode.name == node) {
Good point, but yes, getters/setters, and they should be addressed later on.

On 2012/08/02 05:44:53, Roman wrote:
> Can now (context.isFunction()) be false?

https://chromiumcodereview.appspot.com/10828121/diff/1/lib/compiler/implement...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10828121/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/unparser.dart:104: final newName =
renamer.renameIdentifier(name);
It should be used for getters/setters, maybe even methods.

Let's see how thing goes and rename then.

On 2012/08/02 05:44:53, Roman wrote:
> Looks like now renameIdentifier is only used for function names or
constructors,
> maybe rename the method so it is more clear what is it used for?