Improve renaming of constructors and factories.

lib/compiler/implementation/tree/unparser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Unparser implements Visitor {
   final Renamer renamer;
   StringBuffer sb;
 
   Unparser([this.renamer = const Renamer()]);
 
@@ skipping 82 matching lines @@
       sb.add(' ');
     }
     if (node.getOrSet !== null) {
       add(node.getOrSet.value);
       sb.add(' ');
     }
     // TODO(antonm): that's a workaround as currently FunctionExpression
     // names are modelled with Send and it emits operator[] as only
     // operator, without [] which are expected to be emitted with
     // arguments.
+    emitName(Identifier name) {
+      final newName = renamer.renameIdentifier(name);

[Roman, 2012/08/02 05:44:53]

Looks like now renameIdentifier is only used for function names or constructors,
maybe rename the method so it is more clear what is it used for?

[Anton Muhin, 2012/08/03 13:57:57]

It should be used for getters/setters, maybe even methods.

Let's see how thing goes and rename then.

On 2012/08/02 05:44:53, Roman wrote:

+      if (newName === null) {
+        visit(name);
+      } else {
+        sb.add(newName);
+      }
+    }
     if (node.name is Send) {
       Send send = node.name;
       assert(send is !SendSet);
-      visit(send.receiver);
       if (!send.isOperator) {
         // Looks like a factory method.
+        emitName(send.receiver);
         sb.add('.');
+      } else {
+        visit(send.receiver);
       }
       visit(send.selector);
     } else {
-      visit(node.name);
+      if (node.name !== null) emitName(node.name);
     }
     visit(node.parameters);
     visit(node.initializers);
     visit(node.body);
   }
 
   visitIdentifier(Identifier node) {
-    String newName = renamer.renameIdentifier(node);
-    if (newName == null) {
-      add(node.token.value);
-    } else {
-      sb.add(newName);
-    }
+    add(node.token.value);
   }
 
   visitIf(If node) {
     add(node.ifToken.value);
     visit(node.condition);
     visit(node.thenPart);
     if (node.hasElsePart) {
       add(node.elseToken.value);
       sb.add(' ');
       visit(node.elsePart);
@@ skipping 376 matching lines @@
       sb.add(' ');
     }
     visit(node.name);
     if (node.typeParameters !== null) {
       visit(node.typeParameters);
     }
     visit(node.formals);
     add(node.endToken.value);
   }
 }