Issue 10827353: Fix a performance regressions introduced by r10632.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827353: Fix a performance regressions introduced by r10632. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen

Modified:
8 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a performance regressions introduced by r10632. This gives the compiler the exact same behaviour as before. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10891

Patch Set 2 : Clean up FunctionElement.isInstanceMember and remove redundent code. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	lib/compiler/implementation/elements/elements.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
	M	lib/compiler/implementation/js_backend/backend.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM if you fix isInstanceMember. https://chromiumcodereview.appspot.com/10827353/diff/1/lib/compiler/implementation/js_backend/native_emitter.dart File lib/compiler/implementation/js_backend/native_emitter.dart (right): https://chromiumcodereview.appspot.com/10827353/diff/1/lib/compiler/implementation/js_backend/native_emitter.dart#newcode116 lib/compiler/implementation/js_backend/native_emitter.dart:116: if (member.isInstanceMember() && !member.isConstructor()) ...

8 years, 4 months ago (2012-08-15 16:10:30 UTC) #2

LGTM!

Expand Messages | Collapse Messages

Issue 10827353: Fix a performance regressions introduced by r10632. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Clean up FunctionElement.isInstanceMember and remove redundent code. #

Messages