lib/compiler/implementation/elements/elements.dart - Issue 10827353: Fix a performance regressions introduced by r10632.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/elements/elements.dart

Issue 10827353: Fix a performance regressions introduced by r10632. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Clean up FunctionElement.isInstanceMember and remove redundent code. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/elements/elements.dart

diff --git a/lib/compiler/implementation/elements/elements.dart b/lib/compiler/implementation/elements/elements.dart

index 778084f1ac497624543c7427eeb4448360e779c7..d62fa32eca3685c404d1df58c42696700b867983 100644

--- a/lib/compiler/implementation/elements/elements.dart

+++ b/lib/compiler/implementation/elements/elements.dart

@@ -836,8 +836,7 @@ class FunctionElement extends Element {

bool isInstanceMember() {

return isMember()

- && kind != ElementKind.GENERATIVE_CONSTRUCTOR

- && !modifiers.isFactory()

+ && !isConstructor()

&& !modifiers.isStatic();

}

« no previous file with comments | « no previous file | lib/compiler/implementation/js_backend/backend.dart » ('j') | no next file with comments »