Start moving non-platform libraries from lib/ to pkg/ .

Start moving non-platform libraries from lib/ to pkg/ .
Committed: https://code.google.com/p/dart/source/detail?r=10655

[dgrove, 2012-08-08 17:25:52]

Starting to move non-dart: libraries from lib/ to pkg/

[Bob Nystrom, 2012-08-08 17:32:24]

https://chromiumcodereview.appspot.com/10827227/diff/1/lib/i18n/bidi_formatte...
File lib/i18n/bidi_formatter.dart (left):

https://chromiumcodereview.appspot.com/10827227/diff/1/lib/i18n/bidi_formatte...
lib/i18n/bidi_formatter.dart:1: // Copyright (c) 2012, the Dart project authors.
 Please see the AUTHORS file
I see this stuff is deleted, but I don't see it added under pkg/. Am I looking
at the code review wrong?

https://chromiumcodereview.appspot.com/10827227/diff/1/tests/lib/i18n/bidi_fo...
File tests/lib/i18n/bidi_format_test.dart (right):

https://chromiumcodereview.appspot.com/10827227/diff/1/tests/lib/i18n/bidi_fo...
tests/lib/i18n/bidi_format_test.dart:6: #library('bidi_format_test');
If we intend to organize these like normal pub packages, then the tests would be
with the package:

pkg/
  i18n/
    intl.dart
    test/
      intl_test.dart

If we don't want them in the SDK, we could still strip them from that, but I
think stuff under pkg/ should probably be organized according to the
(documentation forthcoming) pub package conventions.

That has the nice side-effect of giving us a place to dogfood how pub will work
with those conventions (for example, being able to run tests through pub).

https://chromiumcodereview.appspot.com/10827227/diff/1/utils/apidoc/html_diff...
File utils/apidoc/html_diff.dart (right):

https://chromiumcodereview.appspot.com/10827227/diff/1/utils/apidoc/html_diff...
utils/apidoc/html_diff.dart:121: for(var e in _mirrors.libraries().getKeys()) {
print("Lib: $e"); }
Debug code?

[Ivan Posva, 2012-08-08 17:47:54]

LGTM under the assumption that the missing files are properly preserved, or
there is a reason for them to be deleted.

-Ivan

https://chromiumcodereview.appspot.com/10827227/diff/1/lib/i18n/bidi_formatte...
File lib/i18n/bidi_formatter.dart (left):

https://chromiumcodereview.appspot.com/10827227/diff/1/lib/i18n/bidi_formatte...
lib/i18n/bidi_formatter.dart:1: // Copyright (c) 2012, the Dart project authors.
 Please see the AUTHORS file
On 2012/08/08 17:32:24, Bob Nystrom wrote:
> I see this stuff is deleted, but I don't see it added under pkg/. Am I looking
> at the code review wrong?

I am assuming this is because of gcl not properly keeping track of svn moves?

https://chromiumcodereview.appspot.com/10827227/diff/1/tests/lib/i18n/bidi_fo...
File tests/lib/i18n/bidi_format_test.dart (right):

https://chromiumcodereview.appspot.com/10827227/diff/1/tests/lib/i18n/bidi_fo...
tests/lib/i18n/bidi_format_test.dart:6: #library('bidi_format_test');
On 2012/08/08 17:32:24, Bob Nystrom wrote:
> If we intend to organize these like normal pub packages, then the tests would
be
> with the package:
> 
> pkg/
>   i18n/
>     intl.dart
>     test/
>       intl_test.dart
> 
> If we don't want them in the SDK, we could still strip them from that, but I
> think stuff under pkg/ should probably be organized according to the
> (documentation forthcoming) pub package conventions.
> 
> That has the nice side-effect of giving us a place to dogfood how pub will
work
> with those conventions (for example, being able to run tests through pub).

I am very supportive of this idea. This would co-locate the code and its tests
instead of being wildly distributed.

[dgrove, 2012-08-08 17:50:24]

https://chromiumcodereview.appspot.com/10827227/diff/1/lib/i18n/bidi_formatte...
File lib/i18n/bidi_formatter.dart (left):

https://chromiumcodereview.appspot.com/10827227/diff/1/lib/i18n/bidi_formatte...
lib/i18n/bidi_formatter.dart:1: // Copyright (c) 2012, the Dart project authors.
 Please see the AUTHORS file
On 2012/08/08 17:32:24, Bob Nystrom wrote:
> I see this stuff is deleted, but I don't see it added under pkg/. Am I looking
> at the code review wrong?
Sadly, this is a limitation of the code review system. both i18n and logging
directories are, in fact, being moved by this CL.

https://chromiumcodereview.appspot.com/10827227/diff/1/lib/i18n/bidi_formatte...
lib/i18n/bidi_formatter.dart:1: // Copyright (c) 2012, the Dart project authors.
 Please see the AUTHORS file
On 2012/08/08 17:47:54, Ivan Posva wrote:
> On 2012/08/08 17:32:24, Bob Nystrom wrote:
> > I see this stuff is deleted, but I don't see it added under pkg/. Am I
looking
> > at the code review wrong?
> 
> I am assuming this is because of gcl not properly keeping track of svn moves?

exactly - in particular, svn directory moves.

[Bob Nystrom, 2012-08-08 19:58:02]

LGTM assuming the tests get moved into the packages.

[dgrove, 2012-08-08 20:37:13]

On 2012/08/08 19:58:02, Bob Nystrom wrote:
> LGTM assuming the tests get moved into the packages.

I was planning to do that as a follow-on CL.

[Bob Nystrom, 2012-08-08 20:56:22]

On 2012/08/08 20:37:13, dgrove wrote:
> On 2012/08/08 19:58:02, Bob Nystrom wrote:
> > LGTM assuming the tests get moved into the packages.
> 
> I was planning to do that as a follow-on CL.

That works too. LGTM!

[kasperl, 2012-08-09 06:51:50]

LGTM.

https://chromiumcodereview.appspot.com/10827227/diff/1/tests/lib/i18n/bidi_fo...
File tests/lib/i18n/bidi_format_test.dart (right):

https://chromiumcodereview.appspot.com/10827227/diff/1/tests/lib/i18n/bidi_fo...
tests/lib/i18n/bidi_format_test.dart:8: #import('../../../pkg/i18n/intl.dart');
I guess it is pretty important that we get this changed to
#import("package:i18n/intl.dart") soon -- but that requires us to think about
how we plan on running tests after the move. As far as I can tell, we will need
a pubspec for all test suites and we will need to run pub as part of 'gclient
runhooks' to set up the links correctly.

[Bob Nystrom, 2012-08-09 15:50:08]

https://chromiumcodereview.appspot.com/10827227/diff/1/tests/lib/i18n/bidi_fo...
File tests/lib/i18n/bidi_format_test.dart (right):

https://chromiumcodereview.appspot.com/10827227/diff/1/tests/lib/i18n/bidi_fo...
tests/lib/i18n/bidi_format_test.dart:8: #import('../../../pkg/i18n/intl.dart');
On 2012/08/09 06:51:50, kasperl wrote:
> I guess it is pretty important that we get this changed to
> #import("package:i18n/intl.dart") soon -- but that requires us to think about
> how we plan on running tests after the move. As far as I can tell, we will
need
> a pubspec for all test suites and we will need to run pub as part of 'gclient
> runhooks' to set up the links correctly.

This will get a little better when the tests are moved to be with the package.
Then it will just be:

#import('../intl.dart');

But being able to use a 'package:' URL here might be nice.

[dgrove, 2012-08-14 16:19:04]

Start moving non-platform libraries from lib/ to pkg/

[dgrove, 2012-08-14 16:20:01]

I needed up to upload a new version of this change as more files came in before
I could commit.

[Ivan Posva, 2012-08-15 04:00:13]

LGTM -ip