Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 10827209: Unify class ids and snapshot object ids list so that we don't have disparate and sometimes confusin… (Closed)

Created:
8 years, 4 months ago by siva
Modified:
8 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Unify class ids and snapshot object ids list so that we don't have disparate and sometimes confusing values. - Remove instance_kind_ field from RawClass. - Rename all class id names to have a Cid suffix. - Remove code from object.h and object_store.h which dealt with object ids of predefined classes for snapshots. Committed: https://code.google.com/p/dart/source/detail?r=10418

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+929 lines, -1341 lines) Patch
M vm/assembler_macros_ia32.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M vm/assembler_macros_x64.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M vm/class_finalizer.cc View 1 2 3 4 5 1 chunk +35 lines, -35 lines 0 comments Download
M vm/class_table.cc View 1 2 3 4 5 3 chunks +7 lines, -7 lines 0 comments Download
M vm/dart_api_impl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M vm/dart_api_impl.cc View 1 2 3 4 5 8 chunks +11 lines, -11 lines 0 comments Download
M vm/dart_api_message.cc View 1 2 3 4 5 24 chunks +37 lines, -45 lines 0 comments Download
M vm/flow_graph_compiler.cc View 1 2 3 4 5 3 chunks +15 lines, -15 lines 0 comments Download
M vm/flow_graph_compiler_ia32.cc View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M vm/flow_graph_compiler_x64.cc View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M vm/flow_graph_optimizer.cc View 1 2 3 4 5 9 chunks +29 lines, -29 lines 0 comments Download
M vm/freelist.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M vm/heap.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M vm/heap_profiler.cc View 1 2 3 4 5 14 chunks +30 lines, -30 lines 0 comments Download
M vm/il_printer.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M vm/intermediate_language.h View 1 2 3 4 5 11 chunks +13 lines, -13 lines 0 comments Download
M vm/intermediate_language_ia32.cc View 1 2 3 4 5 37 chunks +56 lines, -54 lines 0 comments Download
M vm/intermediate_language_x64.cc View 1 2 3 4 5 37 chunks +56 lines, -54 lines 0 comments Download
M vm/intrinsifier_ia32.cc View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M vm/intrinsifier_x64.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M vm/object.h View 1 2 3 4 5 9 chunks +9 lines, -53 lines 0 comments Download
M vm/object.cc View 1 2 3 4 5 64 chunks +147 lines, -372 lines 0 comments Download
M vm/object_store.h View 1 2 3 4 5 2 chunks +0 lines, -61 lines 0 comments Download
M vm/object_store.cc View 1 2 3 4 5 1 chunk +0 lines, -182 lines 0 comments Download
M vm/object_test.cc View 1 2 3 4 5 2 chunks +9 lines, -9 lines 0 comments Download
M vm/raw_object.h View 1 2 3 4 5 6 chunks +106 lines, -104 lines 0 comments Download
M vm/raw_object.cc View 1 2 3 4 5 5 chunks +60 lines, -71 lines 0 comments Download
M vm/raw_object_snapshot.cc View 1 2 3 4 5 32 chunks +37 lines, -35 lines 0 comments Download
M vm/snapshot.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M vm/snapshot.cc View 1 2 3 4 5 22 chunks +175 lines, -110 lines 0 comments Download
A vm/snapshot_ids.h View 1 chunk +43 lines, -0 lines 0 comments Download
M vm/stub_code_ia32.cc View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M vm/stub_code_x64.cc View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M vm/symbols.h View 1 2 3 4 5 4 chunks +7 lines, -6 lines 0 comments Download
M vm/symbols.cc View 1 2 3 4 5 3 chunks +9 lines, -8 lines 0 comments Download
M vm/vm_sources.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
8 years, 4 months ago (2012-08-08 00:10:48 UTC) #1
regis
8 years, 4 months ago (2012-08-08 00:39:56 UTC) #2
LGTM

This must have been painful...

Thanks!

Powered by Google App Engine
This is Rietveld 408576698