Issue 10826299: Fix crash bug when replacing a definition with a definition that has no uses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826299: Fix crash bug when replacing a definition with a definition that has no uses. (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
zerny-google

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix crash bug when replacing a definition with a definition that has no uses. TEST=vm/intermediate_language_test.cc Committed: https://code.google.com/p/dart/source/detail?r=10630

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	vm/intermediate_language.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	vm/intermediate_language_test.cc	View		1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zerny-google

lgtm. https://chromiumcodereview.appspot.com/10826299/diff/1/vm/intermediate_language_test.cc File vm/intermediate_language_test.cc (right): https://chromiumcodereview.appspot.com/10826299/diff/1/vm/intermediate_language_test.cc#newcode45 vm/intermediate_language_test.cc:45: EXPECT(def1->use_list() == use4); Maybe check a few more ...

8 years, 4 months ago (2012-08-14 11:04:36 UTC) #2

Florian Schneider

8 years, 4 months ago (2012-08-14 11:17:17 UTC) #3

https://chromiumcodereview.appspot.com/10826299/diff/1/vm/intermediate_langua...
File vm/intermediate_language_test.cc (right):

https://chromiumcodereview.appspot.com/10826299/diff/1/vm/intermediate_langua...
vm/intermediate_language_test.cc:45: EXPECT(def1->use_list() == use4);
On 2012/08/14 11:04:36, zerny wrote:
> Maybe check a few more properties here:
> 
> EXPECT(def2->use_list() == NULL);
> EXPECT(use4->definition() == def1);

Done. Good point. I forgot to set the uselist of def2 to NULL.

Expand Messages | Collapse Messages