vm/intermediate_language_test.cc - Issue 10826299: Fix crash bug when replacing a definition with a definition that has no uses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/intermediate_language_test.cc

Issue 10826299: Fix crash bug when replacing a definition with a definition that has no uses. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/intermediate_language_test.cc

===================================================================

--- vm/intermediate_language_test.cc (revision 10621)

+++ vm/intermediate_language_test.cc (working copy)

@@ -39,6 +39,10 @@

BindInstr* bind = new BindInstr(BindInstr::kUsed, use2);

bind->RemoveInputUses();

EXPECT(def1->use_list() == NULL);

+ // Test replacing with a definition without uses.

+ UseVal* use4 = new UseVal(def2);

+ def2->ReplaceUsesWith(def1);

+ EXPECT(def1->use_list() == use4);

zerny-google 2012/08/14 11:04:36 Maybe check a few more properties here: EXPECT(de

Florian Schneider 2012/08/14 11:17:17 Done. Good point. I forgot to set the uselist of d

}

} // namespace dart

« no previous file with comments | « vm/intermediate_language.cc ('k') | no next file » | no next file with comments »