Collect referenced classes recursively.

Collect referenced classes recursively.

Committed: https://code.google.com/p/dart/source/detail?r=10556

[Anton Muhin, 2012-08-13 08:01:01]

https://chromiumcodereview.appspot.com/10826259/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10826259/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:157: new
ReferencedElementCollector(
please, do not duplicate the code, but move it below under flag or introduce a
helper

https://chromiumcodereview.appspot.com/10826259/diff/1/tests/language/languag...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/10826259/diff/1/tests/language/languag...
tests/language/language.status:295: syntax_test/47: Fail  # Test counts on const
default constructor having body, we omit it because it has empty body.
?

[Roman, 2012-08-13 08:14:06]

https://chromiumcodereview.appspot.com/10826259/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10826259/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:157: new
ReferencedElementCollector(
On 2012/08/13 08:01:01, Anton Muhin wrote:
> please, do not duplicate the code, but move it below under flag or introduce a
> helper

Done.

https://chromiumcodereview.appspot.com/10826259/diff/1/tests/language/languag...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/10826259/diff/1/tests/language/languag...
tests/language/language.status:295: syntax_test/47: Fail  # Test counts on const
default constructor having body, we omit it because it has empty body.
On 2012/08/13 08:01:01, Anton Muhin wrote:
> ?

Rephrased.

[Anton Muhin, 2012-08-13 08:15:30]

lgtm w/ comments addressed.

https://chromiumcodereview.appspot.com/10826259/diff/4/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10826259/diff/4/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:144: void
collectElement(Element element) {
nit: please, do not shadow the field.

https://chromiumcodereview.appspot.com/10826259/diff/4/tests/language/languag...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/10826259/diff/4/tests/language/languag...
tests/language/language.status:295: syntax_test/47: Fail  # We should get
compile-time error on const constructor having body. But we don't emit default
constructors with empty body.
Please, move to triaged.

[Roman, 2012-08-13 08:23:08]

https://chromiumcodereview.appspot.com/10826259/diff/4/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10826259/diff/4/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:144: void
collectElement(Element element) {
On 2012/08/13 08:15:30, Anton Muhin wrote:
> nit: please, do not shadow the field.

Renamed field to rootElement.

https://chromiumcodereview.appspot.com/10826259/diff/4/tests/language/languag...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/10826259/diff/4/tests/language/languag...
tests/language/language.status:295: syntax_test/47: Fail  # We should get
compile-time error on const constructor having body. But we don't emit default
constructors with empty body.
On 2012/08/13 08:15:30, Anton Muhin wrote:
> Please, move to triaged.

Done.

[Anton Muhin, 2012-08-13 08:27:44]

thanks!